Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2096833002: Revert of Data structures for Safe Browsing subresource filtering rules. (Closed)

Created:
4 years, 6 months ago by engedy
Modified:
4 years, 6 months ago
CC:
battre
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Data structures for Safe Browsing subresource filtering rules. (patchset #1 id:1 of https://codereview.chromium.org/2094803003/ ) Reason for revert: Something magical taking place on chromium.chrome Linux x64. Reverting again. Original issue's description: > Reland of Data structures for Safe Browsing subresource filtering rules. (patchset #1 id:1 of https://codereview.chromium.org/2098453002/ ) > > Reason for revert: > Build failure could not be reproduced on any other builder, nor locally, nor on a locally run buildbot slave with the same configuration. Build output is void of any error details. > > Speculative reland to verify that the failure is real, and not just the builder needing a clobber. > > Original issue's description: > > Revert of Data structures for Safe Browsing subresource filtering rules. (patchset #4 id:160001 of https://codereview.chromium.org/2086213003/ ) > > > > Reason for revert: > > I think this is causing compile errors on > > https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/12018. > > > > [5683/25038] STAMP obj/components/subresource_filter/core/common/flat/flatbuffer_gen.inputdeps.stamp > > [5684/25038] ACTION //components/subresource_filter/core/common/flat:flatbuffer_gen(//build/toolchain/linux:clang_x64) > > FAILED: gen/components/subresource_filter/core/common/flat/rules_generated.h > > python ../../build/gn_run_binary.py flatc -c -o gen/components/subresource_filter/core/common/flat ../../components/subresource_filter/core/common/flat/rules.fbs > > > > Original issue's description: > > > Data structures for Safe Browsing subresource filtering rules. > > > > > > The rules are defined in two formats: > > > > > > 1) Protocol Buffers, which is used as the wire format for transferring the > > > rules, and is intended to remain relatively stable. > > > > > > 2) FlatBuffers, which is used internally as a compact representation of the > > > rules, and which can be memory mapped into renderer processes directly. > > > > > > This CL also fixes GYP files for flatc for iOS. > > > > > > BUG=609747 > > > > > > Committed: https://crrev.com/2f6afa6d80d6c2addb3b95626140327570151e14 > > > Cr-Commit-Position: refs/heads/master@{#401563} > > > > TBR=engedy@chromium.org,pkalinnikov@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=609747 > > > > Committed: https://crrev.com/b5156c9ef3a959038e2ca485d6e43c559bd57b4a > > Cr-Commit-Position: refs/heads/master@{#401572} > > TBR=pkalinnikov@chromium.org,hbos@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=609747 > > Committed: https://crrev.com/19a4c0cd8e6b0b60287f4f887f85067b19b78985 > Cr-Commit-Position: refs/heads/master@{#401673} TBR=pkalinnikov@chromium.org,hbos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609747 Committed: https://crrev.com/cfac45b10f2a1d36d84bff45c38817fd0d58aeda Cr-Commit-Position: refs/heads/master@{#401696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -386 lines) Patch
M components/subresource_filter.gypi View 3 chunks +2 lines, -38 lines 0 comments Download
M components/subresource_filter/core/common/BUILD.gn View 2 chunks +1 line, -7 lines 0 comments Download
D components/subresource_filter/core/common/flat/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D components/subresource_filter/core/common/flat/rules.fbs View 1 chunk +0 lines, -117 lines 0 comments Download
D components/subresource_filter/core/common/proto/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D components/subresource_filter/core/common/proto/rules.proto View 1 chunk +0 lines, -196 lines 0 comments Download
M third_party/flatbuffers/flatbuffers.gyp View 4 chunks +1 line, -5 lines 0 comments Download
M third_party/flatbuffers/flatc.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
engedy
Created Revert of Data structures for Safe Browsing subresource filtering rules.
4 years, 6 months ago (2016-06-23 20:07:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096833002/1
4 years, 6 months ago (2016-06-23 20:07:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 20:08:21 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 20:09:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfac45b10f2a1d36d84bff45c38817fd0d58aeda
Cr-Commit-Position: refs/heads/master@{#401696}

Powered by Google App Engine
This is Rietveld 408576698