Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: Source/core/animation/TimingInput.cpp

Issue 209683002: Web Animations API: Remove literal defaults from TimingInput (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/TimingInput.cpp
diff --git a/Source/core/animation/TimingInput.cpp b/Source/core/animation/TimingInput.cpp
index e8e325c643b9729145ecd9130ac38997965e9dc7..605f73fd22b79afbd12eef52a6d8a6eed8608fc5 100644
--- a/Source/core/animation/TimingInput.cpp
+++ b/Source/core/animation/TimingInput.cpp
@@ -107,11 +107,11 @@ Timing TimingInput::convert(const Dictionary& timingInputDictionary)
// FIXME: This method needs to be refactored to handle invalid
// null, NaN, Infinity values better.
// See: http://www.w3.org/TR/WebIDL/#es-double
- double startDelay = 0;
+ double startDelay = Timing::defaults().startDelay;
timingInputDictionary.get("delay", startDelay);
setStartDelay(result, startDelay);
- double endDelay = 0;
+ double endDelay = Timing::defaults().endDelay;
timingInputDictionary.get("endDelay", endDelay);
setEndDelay(result, endDelay);
@@ -119,11 +119,11 @@ Timing TimingInput::convert(const Dictionary& timingInputDictionary)
timingInputDictionary.get("fill", fillMode);
setFillMode(result, fillMode);
- double iterationStart = 0;
+ double iterationStart = Timing::defaults().iterationStart;
timingInputDictionary.get("iterationStart", iterationStart);
setIterationStart(result, iterationStart);
- double iterationCount = 1;
+ double iterationCount = Timing::defaults().iterationCount;
timingInputDictionary.get("iterations", iterationCount);
setIterationCount(result, iterationCount);
@@ -133,7 +133,7 @@ Timing TimingInput::convert(const Dictionary& timingInputDictionary)
setIterationDuration(result, iterationDuration);
}
- double playbackRate = 1;
+ double playbackRate = Timing::defaults().playbackRate;
timingInputDictionary.get("playbackRate", playbackRate);
setPlaybackRate(result, playbackRate);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698