media/vpx: Add support for VP9 alpha channel

media/vpx: Add support for VP9 alpha channel

TEST=<new pipeline integration test>

Committed: https://crrev.com/f12d64fb2c759a2e62653b08b663a79299f63d4c
Cr-Commit-Position: refs/heads/master@{#402649}

[vignesh, 2016-06-23 21:23:52]

vigneshv@chromium.org changed reviewers:
+ dalecurtis@chromium.org, fgalligan@chromium.org

[vignesh, 2016-06-23 21:23:52]

This is pretty much the same CL as https://codereview.chromium.org/1561703002/
which was reverted because of a timeout in chromium valgrind bot.

Couple of things:
* I have removed the kClockless from the new tests (since none of the other test
has it - we can make all of the tests kClockless in a subsequent CL if we want -
just want to avoid an irrelevant change to break this CL).
* Is there a way to dry run chromium valgrind bot before submitting? it seems to
pass the tests in my local build.

[ddorwin, 2016-06-23 21:28:02]

Is there a BUG for this? Is there a way for applications to detect that the user
agent supports alpha channel? Is that part of the profile string?

[vignesh, 2016-06-23 21:30:09]

On 2016/06/23 21:28:02, ddorwin wrote:
> Is there a BUG for this? 

None that i'm aware of. This is merely removing the artificial restriction of
not accepting vp9 streams with alpha channel.

> Is there a way for applications to detect that the user
> agent supports alpha channel? Is that part of the profile string?

I don't think so. We've had VP8 alpha channel like this for more than a year now
and afaik there's not way to detect support for that either.

[DaleCurtis, 2016-06-23 21:41:58]

lgtm, as you say this is no different than the vp8a we already have, in the
future it'd be nice to expose this via canPlayType/isTypeSupported() somehow.

https://codereview.chromium.org/2096813002/diff/1/media/test/pipeline_integra...
File media/test/pipeline_integration_test.cc (right):

https://codereview.chromium.org/2096813002/diff/1/media/test/pipeline_integra...
media/test/pipeline_integration_test.cc:2203: ASSERT_EQ(PIPELINE_OK,
Start("bear-vp9a.webm", kClockless));
Still kClockless?

[vignesh, 2016-06-23 21:44:31]

Also added the test files that i missed out in PS1.

https://codereview.chromium.org/2096813002/diff/1/media/test/pipeline_integra...
File media/test/pipeline_integration_test.cc (right):

https://codereview.chromium.org/2096813002/diff/1/media/test/pipeline_integra...
media/test/pipeline_integration_test.cc:2203: ASSERT_EQ(PIPELINE_OK,
Start("bear-vp9a.webm", kClockless));
On 2016/06/23 21:41:58, DaleCurtis wrote:
> Still kClockless?

oops, left out a local change. fixed now.

[vignesh, 2016-06-27 16:54:47]

The CQ bit was checked by vigneshv@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 16:55:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 19:24:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 19:24:39]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[vignesh, 2016-06-27 19:27:53]

CQ dry run looks ok.

Ok to land this?

[vignesh, 2016-06-28 17:36:30]

The CQ bit was checked by vigneshv@chromium.org

[vignesh, 2016-06-28 17:36:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2096813002/#ps20001
(title: "add test files for real")

[commit-bot: I haz the power, 2016-06-28 17:37:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 20:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 20:04:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vignesh, 2016-06-28 22:13:57]

The CQ bit was checked by vigneshv@chromium.org

[commit-bot: I haz the power, 2016-06-28 22:15:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 01:58:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 02:00:47]

Description was changed from

==========
media/vpx: Add support for VP9 alpha channel

TEST=<new pipeline integration test>
==========

to

==========
media/vpx: Add support for VP9 alpha channel

TEST=<new pipeline integration test>

Committed: https://crrev.com/f12d64fb2c759a2e62653b08b663a79299f63d4c
Cr-Commit-Position: refs/heads/master@{#402649}
==========

[commit-bot: I haz the power, 2016-06-29 02:00:48]

Patchset 2 (id:??) landed as
https://crrev.com/f12d64fb2c759a2e62653b08b663a79299f63d4c
Cr-Commit-Position: refs/heads/master@{#402649}