Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: third_party/WebKit/Source/core/frame/DOMVisualViewport.h

Issue 2096783004: Seperate visualviewportchanged event into scroll and resize events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/DOMVisualViewport.h
diff --git a/third_party/WebKit/Source/core/frame/DOMVisualViewport.h b/third_party/WebKit/Source/core/frame/DOMVisualViewport.h
index 95f35e689c17886c08bd1bd4c41db58a7a467ab4..6caf4991c1e29915301a28402057a358ba9303e4 100644
--- a/third_party/WebKit/Source/core/frame/DOMVisualViewport.h
+++ b/third_party/WebKit/Source/core/frame/DOMVisualViewport.h
@@ -32,15 +32,16 @@
#define DOMVisualViewport_h
#include "bindings/core/v8/ScriptWrappable.h"
+#include "core/dom/ExecutionContext.h"
+#include "core/events/EventTarget.h"
#include "platform/heap/Handle.h"
namespace blink {
class LocalDOMWindow;
+class ExecutionContext;
-class DOMVisualViewport final
- : public GarbageCollected<DOMVisualViewport>
- , public ScriptWrappable {
+class DOMVisualViewport final : public EventTargetWithInlineData {
bokan 2016/06/24 21:52:37 Since EventTarget is GCFinalized and has a virtual
DEFINE_WRAPPERTYPEINFO();
public:
static DOMVisualViewport* create(LocalDOMWindow* window)
@@ -50,6 +51,10 @@ public:
DECLARE_VIRTUAL_TRACE();
+ // EventTarget overrides:
+ const AtomicString& interfaceName() const override;
+ ExecutionContext* getExecutionContext() const override;
+
double scrollLeft();
double scrollTop();
void setScrollLeft(double x);

Powered by Google App Engine
This is Rietveld 408576698