Seperate visualviewportchanged event into scroll and resize events

third_party/WebKit/Source/core/frame/VisualViewport.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 78 matching lines @@
 
 void VisualViewport::updateStyleAndLayoutIgnorePendingStylesheets()
 {
     if (!mainFrame())
         return;
 
     if (Document* document = mainFrame()->document())
         document->updateStyleAndLayoutIgnorePendingStylesheets();
 }
 
-void VisualViewport::enqueueChangedEvent()
+void VisualViewport::enqueueScrollEvent()
 {
     if (!RuntimeEnabledFeatures::visualViewportAPIEnabled())
         return;
 
     if (Document* document = mainFrame()->document())
-        document->enqueueVisualViewportChangedEvent();
+        document->enqueueVisualViewportScrollEvent();
+}
+
+void VisualViewport::enqueueResizeEvent()
+{
+    if (!RuntimeEnabledFeatures::visualViewportAPIEnabled())
+        return;
+
+    if (Document* document = mainFrame()->document())
+        document->enqueueVisualViewportResizeEvent();
 }
 
 void VisualViewport::setSize(const IntSize& size)
 {
     if (m_size == size)
         return;
 
     TRACE_EVENT2("blink", "VisualViewport::setSize", "width", size.width(), "height", size.height());
     bool widthDidChange = size.width() != m_size.width();
     m_size = size;
 
     if (m_innerViewportContainerLayer) {
         m_innerViewportContainerLayer->setSize(FloatSize(m_size));
 
         // Need to re-compute sizes for the overlay scrollbars.
         initializeScrollbars();
     }
 
     if (!mainFrame())
         return;
 
-    enqueueChangedEvent();
+    enqueueScrollEvent();

[bokan, 2016/06/24 21:52:37]

Why are we sending a scroll event when the size changes? This should be
enqueueResizeEvent, no?

[ymalik, 2016/06/27 14:10:01]

Yes!

 
     bool autosizerNeedsUpdating = widthDidChange
         && mainFrame()->settings()
         && mainFrame()->settings()->textAutosizingEnabled();
 
     if (autosizerNeedsUpdating) {
         // This needs to happen after setting the m_size member since it'll be read in the update call.
         if (TextAutosizer* textAutosizer = mainFrame()->document()->textAutosizer())
             textAutosizer->updatePageInfoInAllFrames();
     }
@@ skipping 146 matching lines @@
 {
     if (!mainFrame())
         return;
 
     bool valuesChanged = false;
 
     if (scale != m_scale) {
         m_scale = scale;
         valuesChanged = true;
         frameHost().chromeClient().pageScaleFactorChanged();
+        enqueueResizeEvent();
     }
 
     FloatPoint clampedOffset(clampOffsetToBoundaries(location));
 
     if (clampedOffset != m_offset) {
         m_offset = clampedOffset;
         scrollAnimator().setCurrentPosition(m_offset);
 
         // SVG runs with accelerated compositing disabled so no ScrollingCoordinator.
         if (ScrollingCoordinator* coordinator = frameHost().page().scrollingCoordinator())
             coordinator->scrollableAreaScrollLayerDidChange(this);
 
         if (!frameHost().settings().inertVisualViewport()) {
             if (Document* document = mainFrame()->document())
                 document->enqueueScrollEventForNode(document);
         }
 
+        enqueueScrollEvent();
+
         mainFrame()->loader().client()->didChangeScrollOffset();
         valuesChanged = true;
     }
 
     if (!valuesChanged)
         return;
 
-    enqueueChangedEvent();
-
     InspectorInstrumentation::didUpdateLayout(mainFrame());
     mainFrame()->loader().saveScrollState();
 
     clampToBoundaries();
 }
 
 bool VisualViewport::magnifyScaleAroundAnchor(float magnifyDelta, const FloatPoint& anchor)
 {
     const float oldPageScale = scale();
     const float newPageScale = frameHost().chromeClient().clampPageScaleFactorToLimits(
@@ skipping 506 matching lines @@
     } else if (graphicsLayer == m_rootTransformLayer.get()) {
         name =  "Root Transform Layer";
     } else {
         ASSERT_NOT_REACHED();
     }
 
     return name;
 }
 
 } // namespace blink