third_party/WebKit/LayoutTests/fast/dom/viewport/scroll-resize-events-fired.html - Issue 2096783004: Seperate visualviewportchanged event into scroll and resize events

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/scroll-resize-events-fired.html

Issue 2096783004: Seperate visualviewportchanged event into scroll and resize events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/dom/viewport/scroll-event-fired-window-resized.html ('K') | « third_party/WebKit/LayoutTests/fast/dom/viewport/scroll-event-fired-window-resized.html ('k') | third_party/WebKit/LayoutTests/fast/dom/viewport/visualviewportchanged-event-fired.html » ('j') | third_party/WebKit/Source/core/frame/DOMVisualViewport.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 body {

	4 height: 2000px;

	5 width: 2000px;

	6 }

	7 </style>

	8

	9 <script src="../../../resources/testharness.js"></script>

	10 <script src="../../../resources/testharnessreport.js"></script>

	11 <script>

	12 var numCallsScroll = 0;

	13 var numCallsResize = 0;

	14 var pageScaleFactor = 2;

	15

	16 function viewport() {

	17 return window.visualViewport;

	18 }

	19

	20 var t = async_test('verify that the scroll and resize events get fired on wind ow.visualViewport');

	21

	22 function verifySetViewportOffsets() {

	23 // Set viewport offset.

	24 window.visualViewport.scrollTop = 20;

	25 requestAnimationFrame(function() {

	26 assert_equals(numCallsScroll, 2);

	27 assert_equals(numCallsResize, 1);

	28 window.visualViewport.scrollLeft = 0;

	29 requestAnimationFrame(function() {

	30 assert_equals(numCallsScroll, 3);

	31 assert_equals(numCallsResize, 1);

	32 t.done();

	33 });

	34 });

	35 }

	36

	37 window.onload = t.step_func(function() {

	38 // Turn off smooth scrolling.

	39 internals.settings.setScrollAnimatorEnabled(false);

	40

	41 window.visualViewport.addEventListener('scroll', function(e) {

	42 numCallsScroll++;

	43 });

	44

	45 window.visualViewport.addEventListener('resize', function(e) {

	46 numCallsResize++;

	47 });

	48

	49 // Scroll both viewports.

	50 eventSender.mouseMoveTo(100, 100);

	51 eventSender.continuousMouseScrollBy(100, 100);

	52 assert_equals(numCallsScroll, 0);

	53 assert_equals(numCallsResize, 0);

	54

	55 // TODO(ymalik): Remove hook to internals to pinch-zoom here and browser

	56 // zoom below. This will be required to upstream to w3c repo.

	57 internals.setPageScaleFactor(pageScaleFactor);
	bokan 2016/06/24 21:52:36 Please split up this test into a scroll test and a Please split up this test into a scroll test and a zoom test. Doesn't necessarily have to be separate files but separate test functions in testharness.js ymalik 2016/06/27 14:10:01 We will always have to use internals to scale then Show quoted text On 2016/06/24 21:52:36, bokan wrote: > Please split up this test into a scroll test and a zoom test. Doesn't > necessarily have to be separate files but separate test functions in > testharness.js We will always have to use internals to scale then scroll. Note that the "verifySetViewportOffsets" function above will go away in my next CL since we decided to make the API readonly for V1. bokan 2016/06/27 14:17:03 My comment above was about splitting this test int Show quoted text On 2016/06/27 14:10:01, ymalik wrote: > On 2016/06/24 21:52:36, bokan wrote: > > Please split up this test into a scroll test and a zoom test. Doesn't > > necessarily have to be separate files but separate test functions in > > testharness.js > > We will always have to use internals to scale then scroll. Note that the > "verifySetViewportOffsets" function above will go away in my next CL since we > decided to make the API readonly for V1. My comment above was about splitting this test into one test that scrolls and checks for the scroll event, and another that scales and checks for the resize event. It doesn't have anything to do with the internals method. Testharness failures are pretty tough to narrow down when the tests are large. It's best to have multiple small, targeted tests.
	58

	59 // Verify viewport dimensions exclude scrollbar.

	60 requestAnimationFrame(function() {

	61 assert_equals(numCallsScroll, 0);

	62 assert_equals(numCallsResize, 1);

	63 internals.setVisualViewportOffset(10, 10);

	64 requestAnimationFrame(function() {

	65 assert_equals(numCallsScroll, 1);

	66 assert_equals(numCallsScroll, 1);

	67 verifySetViewportOffsets();

	68 });

	69 });

	70 });

	71 </script>

OLD	NEW