Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2096763002: Reland of land: Refactor process_resources.py to use aapt's --extra-packages (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #3 Refactor process_resources.py to use aapt's --extra-packages Without --extra-packages, we now use the same code-path to generate the current R.java as well as dependent R.java files. Previously, we were combing aapt's R.java with our own template. Our custom template no longer generating assignments for non-array styleable fields within onResourcesLoaded() (matches aapt's behaviour) Reason for reland: Fixed GYP issue & verified all webrtc targets compile. TBR=jbudorick BUG=none Committed: https://crrev.com/ca0837dc170bd670dd5dc818bedaee40ad39b2c1 Cr-Commit-Position: refs/heads/master@{#401653}

Patch Set 1 #

Patch Set 2 : Fix webrtc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -100 lines) Patch
M build/android/gyp/process_resources.py View 1 10 chunks +121 lines, -92 lines 0 comments Download
M build/java_apk.gypi View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
agrieve
Created Reland of land: Refactor process_resources.py to use aapt's --extra-packages
4 years, 6 months ago (2016-06-23 17:22:06 UTC) #1
agrieve
On 2016/06/23 17:22:06, agrieve wrote: > Created Reland of land: Refactor process_resources.py to use aapt's ...
4 years, 6 months ago (2016-06-23 17:26:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096763002/40001
4 years, 6 months ago (2016-06-23 17:26:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-23 18:22:31 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 18:51:14 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca0837dc170bd670dd5dc818bedaee40ad39b2c1
Cr-Commit-Position: refs/heads/master@{#401653}

Powered by Google App Engine
This is Rietveld 408576698