Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2861)

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Issue 2096733002: Fix the bug where focus jumps around on the media router sink list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add selectIndex to externs.js Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/media_router/externs.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
index 8958dbeaaabb089b51ed765be54e89b316277eb5..ecd5810bfda626b3c608c9a2d5f20ea75b5d282f 100644
--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
@@ -1293,14 +1293,15 @@ Polymer({
var focusedSink =
this.$$('#searchResults').itemForElement(focusedElem).sinkItem;
setTimeout(function() {
+ var sinkListPaperMenu = this.$$('#sink-list');
+ var sinks = sinkListPaperMenu.children;
var sinkList = this.$$('#sinkList');
- var sinks = this.$['sink-list-view'].querySelectorAll('paper-item');
- Array.prototype.some.call(sinks, function(sink) {
- if (sinkList.itemForElement(sink).id == focusedSink.id) {
- sink.focus();
- return true;
+ for (var i = 0; i < sinks.length; i++) {
+ if (sinkList.itemForElement(sinks[i]).id == focusedSink.id) {
+ sinkListPaperMenu.selectIndex(i);
+ break;
}
- });
+ }
}.bind(this));
},
« no previous file with comments | « no previous file | chrome/browser/resources/media_router/externs.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698