net/spdy/buffered_spdy_framer.h - Issue 2096713002: Reduce SpdyHeaderBlock copies with move semantics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/buffered_spdy_framer.h

Issue 2096713002: Reduce SpdyHeaderBlock copies with move semantics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clear() does not work after all. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/buffered_spdy_framer.h

diff --git a/net/spdy/buffered_spdy_framer.h b/net/spdy/buffered_spdy_framer.h

index 461e6b579d5b2ddedb51fd178ba5dc97875b6c18..8f04d9ecb2cc482ab9b5eb650212174a30899e16 100644

--- a/net/spdy/buffered_spdy_framer.h

+++ b/net/spdy/buffered_spdy_framer.h

@@ -215,10 +215,10 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramer

SpdyStreamId associated_stream_id,

SpdyPriority priority,

SpdyControlFlags flags,

- const SpdyHeaderBlock* headers);

+ SpdyHeaderBlock headers);

SpdySerializedFrame* CreateSynReply(SpdyStreamId stream_id,

SpdyControlFlags flags,

- const SpdyHeaderBlock* headers);

+ SpdyHeaderBlock headers);

SpdySerializedFrame* CreateRstStream(SpdyStreamId stream_id,

SpdyRstStreamStatus status) const;

SpdySerializedFrame* CreateSettings(const SettingsMap& values) const;

@@ -229,7 +229,7 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramer

SpdySerializedFrame* CreateHeaders(SpdyStreamId stream_id,

SpdyControlFlags flags,

int weight,

- const SpdyHeaderBlock* headers);

+ SpdyHeaderBlock headers);

SpdySerializedFrame* CreateWindowUpdate(SpdyStreamId stream_id,

uint32_t delta_window_size) const;

SpdySerializedFrame* CreateDataFrame(SpdyStreamId stream_id,

@@ -238,7 +238,7 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramer

SpdyDataFlags flags);

SpdySerializedFrame* CreatePushPromise(SpdyStreamId stream_id,

SpdyStreamId promised_stream_id,

- const SpdyHeaderBlock* headers);

+ SpdyHeaderBlock headers);

// Serialize a frame of unknown type.

SpdySerializedFrame SerializeFrame(const SpdyFrameIR& frame) {

« no previous file with comments | « net/quic/test_tools/quic_test_packet_maker.cc ('k') | net/spdy/buffered_spdy_framer.cc » ('j') | no next file with comments »