Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: net/http/bidirectional_stream_unittest.cc

Issue 2096713002: Reduce SpdyHeaderBlock copies with move semantics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clear() does not work after all. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/bidirectional_stream_unittest.cc
diff --git a/net/http/bidirectional_stream_unittest.cc b/net/http/bidirectional_stream_unittest.cc
index 1bf666d9898794482d686721ec1db5a6358f7bb2..ef937d82fd2ba0b265b87cef38e3663ebebb8f8a 100644
--- a/net/http/bidirectional_stream_unittest.cc
+++ b/net/http/bidirectional_stream_unittest.cc
@@ -5,6 +5,7 @@
#include "net/http/bidirectional_stream.h"
#include <memory>
+#include <utility>
#include "base/macros.h"
#include "base/memory/ptr_util.h"
@@ -523,7 +524,7 @@ TEST_F(BidirectionalStreamTest, TestNetLogContainEntries) {
SpdyHeaderBlock trailers;
trailers["foo"] = "bar";
std::unique_ptr<SpdySerializedFrame> response_trailers(
- spdy_util_.ConstructSpdyResponseHeaders(1, trailers, true));
+ spdy_util_.ConstructSpdyResponseHeaders(1, std::move(trailers), true));
MockRead reads[] = {
CreateMockRead(*resp, 1),
@@ -1013,7 +1014,7 @@ TEST_F(BidirectionalStreamTest, TestBufferingWithTrailers) {
SpdyHeaderBlock trailers;
trailers["foo"] = "bar";
std::unique_ptr<SpdySerializedFrame> response_trailers(
- spdy_util_.ConstructSpdyResponseHeaders(1, trailers, true));
+ spdy_util_.ConstructSpdyResponseHeaders(1, std::move(trailers), true));
MockRead reads[] = {
CreateMockRead(*resp, 1),
@@ -1418,7 +1419,7 @@ TEST_P(BidirectionalStreamTest, CancelOrDeleteStreamDuringOnTrailersReceived) {
SpdyHeaderBlock trailers;
trailers["foo"] = "bar";
std::unique_ptr<SpdySerializedFrame> response_trailers(
- spdy_util_.ConstructSpdyResponseHeaders(1, trailers, true));
+ spdy_util_.ConstructSpdyResponseHeaders(1, std::move(trailers), true));
MockRead reads[] = {
CreateMockRead(*resp, 1), CreateMockRead(*response_body_frame, 2),
« no previous file with comments | « no previous file | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698