Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2096693002: Reland of: Refactor process_resources.py to use aapt's --extra-packages (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #2 Refactor process_resources.py to use aapt's --extra-packages Without --extra-packages, we now use the same code-path to generate the current R.java as well as dependent R.java files. Previously, we were combing aapt's R.java with our own template. Our custom template no longer generating assignments for non-array styleable fields within onResourcesLoaded() (matches aapt's behaviour) Reason for reland: Fixed GYP issue & verified all webrtc targets compile. TBR=jbudorick BUG=none Committed: https://crrev.com/f3c8dfe0190ad701a9339436ff1d7f3b1e556e7d Cr-Commit-Position: refs/heads/master@{#401624}

Patch Set 1 #

Patch Set 2 : fix gyp #

Patch Set 3 : rename CreateExtra -> Create #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -90 lines) Patch
M build/android/gyp/process_resources.py View 1 2 8 chunks +102 lines, -82 lines 0 comments Download
M build/java_apk.gypi View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
agrieve
Created Reland of land: Refactor process_resources.py to use aapt's --extra-packages
4 years, 6 months ago (2016-06-23 15:19:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096693002/40001
4 years, 6 months ago (2016-06-23 15:26:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096693002/60001
4 years, 6 months ago (2016-06-23 15:28:15 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-23 16:21:56 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f3c8dfe0190ad701a9339436ff1d7f3b1e556e7d Cr-Commit-Position: refs/heads/master@{#401624}
4 years, 6 months ago (2016-06-23 16:27:25 UTC) #11
agrieve
4 years, 6 months ago (2016-06-23 17:18:14 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2097583002/ by agrieve@chromium.org.

The reason for reverting is: Relanded the wrong patchset! Missing code for
excluding styleable..

Powered by Google App Engine
This is Rietveld 408576698