Issue 2096683003: Add yet another threaded test of WaitSetDispatcher.

Issue 2096683003: Add yet another threaded test of WaitSetDispatcher. (Closed)

Created:
4 years, 6 months ago by viettrungluu

Modified:
4 years, 6 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@work792_wait_set_5.2-x-work791_wait_set_5.1-x-work790_wait_set_5

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add yet another threaded test of WaitSetDispatcher. This time, test waiting from multiple threads. Also, fix a bug: I used Signal() instead of SignalAll(). Oops. R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/1836411b1152a54a87ca04cd07db446c966d44e0

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : doh #

Patch Set 4 : improve test and fix bug #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -3 lines)			Patch
	M	mojo/edk/system/wait_set_dispatcher.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	mojo/edk/system/wait_set_dispatcher_unittest.cc	View	1 2 3	2 chunks	+47 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 2099543002 Patch 40001

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

4 years, 6 months ago (2016-06-24 22:06:23 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
1836411b1152a54a87ca04cd07db446c966d44e0 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages