Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2096683002: Remove Android SampleApp (Closed)

Created:
4 years, 5 months ago by liyuqian
Modified:
4 years, 5 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : SkOSWindow #

Patch Set 3 : String #

Total comments: 1

Patch Set 4 : More removal #

Patch Set 5 : gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1564 lines) Patch
M gyp/SampleApp.gyp View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
M gyp/everything.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gyp/most.gyp View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M gyp/tools.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
D include/views/SkOSWindow_Android.h View 1 1 chunk +0 lines, -53 lines 0 comments Download
M include/views/SkWindow.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
D platform_tools/android/apps/sample_app/build.gradle View 1 chunk +0 lines, -30 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/AndroidManifest.xml View 1 chunk +0 lines, -22 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleActivity.java View 1 chunk +0 lines, -251 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleRenderer.java View 1 chunk +0 lines, -113 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java View 1 chunk +0 lines, -310 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/jni/AndroidKeyToSkKey.h View 1 chunk +0 lines, -34 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.h View 1 chunk +0 lines, -164 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.cpp View 1 chunk +0 lines, -356 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/drawable-hdpi/ic_btn_find_next.png View Binary file 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/drawable-hdpi/ic_btn_find_prev.png View Binary file 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/layout/layout.xml View 1 chunk +0 lines, -17 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/menu/action_bar.xml View 1 chunk +0 lines, -75 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/values/strings.xml View 1 chunk +0 lines, -17 lines 0 comments Download
M platform_tools/android/apps/settings.gradle View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 1 2 3 1 chunk +0 lines, -32 lines 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 1 2 3 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
liyuqian
Android SampleApp is removed in this CL. The general SampleApp will still live for now ...
4 years, 5 months ago (2016-06-23 15:21:07 UTC) #3
liyuqian
SkOSWindow is now removed in Android and the main_android.cpp is reverted for the next CL.
4 years, 5 months ago (2016-06-23 15:40:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096683002/20001
4 years, 5 months ago (2016-06-23 15:40:16 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/4322)
4 years, 5 months ago (2016-06-23 15:43:06 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096683002/40001
4 years, 5 months ago (2016-06-23 15:55:46 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/9250)
4 years, 5 months ago (2016-06-23 16:00:17 UTC) #12
djsollen
https://codereview.chromium.org/2096683002/diff/1/gyp/viewer.gyp File gyp/viewer.gyp (left): https://codereview.chromium.org/2096683002/diff/1/gyp/viewer.gyp#oldcode68 gyp/viewer.gyp:68: 'android_deps.gyp:native_app_glue', drop this into a separate CL. https://codereview.chromium.org/2096683002/diff/40001/platform_tools/android/apps/sample_app/build.gradle File ...
4 years, 5 months ago (2016-06-23 16:21:58 UTC) #13
liyuqian
More removal.
4 years, 5 months ago (2016-06-23 18:24:16 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096683002/80001
4 years, 5 months ago (2016-06-23 18:24:31 UTC) #16
djsollen
lgtm
4 years, 5 months ago (2016-06-23 18:40:50 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-23 18:46:55 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096683002/80001
4 years, 5 months ago (2016-06-23 19:07:10 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/41bb5b40e71411ee39538399ea125986ec760a90
4 years, 5 months ago (2016-06-23 19:08:11 UTC) #23
rmistry
4 years, 5 months ago (2016-06-24 12:01:01 UTC) #24
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2099693002/ by rmistry@google.com.

The reason for reverting is: Testing to see if this CL caused the failures in
Build-Mac-Clang-Arm7-Debug-Android.

Powered by Google App Engine
This is Rietveld 408576698