Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2096663002: [Origin Trials] Only flag feature bindings installed after all install methods have returned (Closed)

Created:
4 years, 6 months ago by iclelland
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, ortuno
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Origin Trials] Only flag feature bindings installed after all install methods have returned This fixes an issue which we haven't run into yet, but will as soon as an origin trial feature tries to install bindings onto core *and* modules at the same time. We need to ensure that we only flag the feature as having had its bindings installed once *all* installation functions have had a chance to install them. Committed: https://crrev.com/7e54fd8b37da95028478b77c1aa524ba20bba393 Cr-Commit-Position: refs/heads/master@{#401888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
iclelland
+r haraken, PTAL, thanks!
4 years, 6 months ago (2016-06-23 14:49:29 UTC) #2
haraken
LGTM but I'd like to consider a way to auto-generate the code to flip the ...
4 years, 6 months ago (2016-06-24 01:01:58 UTC) #3
iclelland
On 2016/06/24 01:01:58, haraken wrote: > LGTM but I'd like to consider a way to ...
4 years, 6 months ago (2016-06-24 03:38:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096663002/1
4 years, 6 months ago (2016-06-24 16:07:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 17:17:40 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 17:20:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e54fd8b37da95028478b77c1aa524ba20bba393
Cr-Commit-Position: refs/heads/master@{#401888}

Powered by Google App Engine
This is Rietveld 408576698