Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: src/crankshaft/hydrogen-instructions.h

Issue 2096653003: [ic] Don't pass receiver and name to LoadGlobalIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@store-name-in-metavector
Patch Set: Removed name parameter. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen-instructions.h
diff --git a/src/crankshaft/hydrogen-instructions.h b/src/crankshaft/hydrogen-instructions.h
index 12a6d92386aba8da0b7a94f7e16c0068e61f4199..f2c9de0cf6b932932f1a05d6c49fa8da57a2bb94 100644
--- a/src/crankshaft/hydrogen-instructions.h
+++ b/src/crankshaft/hydrogen-instructions.h
@@ -4851,16 +4851,14 @@ class HUnknownOSRValue final : public HTemplateInstruction<0> {
HPhi* incoming_value_;
};
-
-class HLoadGlobalGeneric final : public HTemplateInstruction<2> {
+class HLoadGlobalGeneric final : public HTemplateInstruction<1> {
public:
- DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P5(HLoadGlobalGeneric, HValue*,
+ DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P4(HLoadGlobalGeneric,
Handle<String>, TypeofMode,
Handle<TypeFeedbackVector>,
FeedbackVectorSlot);
HValue* context() { return OperandAt(0); }
- HValue* global_object() { return OperandAt(1); }
Handle<String> name() const { return name_; }
TypeofMode typeof_mode() const { return typeof_mode_; }
FeedbackVectorSlot slot() const { return slot_; }
@@ -4877,15 +4875,14 @@ class HLoadGlobalGeneric final : public HTemplateInstruction<2> {
DECLARE_CONCRETE_INSTRUCTION(LoadGlobalGeneric)
private:
- HLoadGlobalGeneric(HValue* context, HValue* global_object,
- Handle<String> name, TypeofMode typeof_mode,
- Handle<TypeFeedbackVector> vector, FeedbackVectorSlot slot)
+ HLoadGlobalGeneric(HValue* context, Handle<String> name,
+ TypeofMode typeof_mode, Handle<TypeFeedbackVector> vector,
+ FeedbackVectorSlot slot)
: name_(name),
typeof_mode_(typeof_mode),
feedback_vector_(vector),
slot_(slot) {
SetOperandAt(0, context);
- SetOperandAt(1, global_object);
set_representation(Representation::Tagged());
SetAllSideEffects();
}
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698