src/crankshaft/arm/lithium-codegen-arm.cc - Issue 2096653003: [ic] Don't pass receiver and name to LoadGlobalIC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/arm/lithium-codegen-arm.cc

Issue 2096653003: [ic] Don't pass receiver and name to LoadGlobalIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@store-name-in-metavector

Patch Set: Removed name parameter. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/arm/lithium-codegen-arm.cc

diff --git a/src/crankshaft/arm/lithium-codegen-arm.cc b/src/crankshaft/arm/lithium-codegen-arm.cc

index 24865cdead41a9e61c0a701712241f0c4c8f6ea6..fac9e869f1d1f8769a048bc518649c567bd0f15a 100644

--- a/src/crankshaft/arm/lithium-codegen-arm.cc

+++ b/src/crankshaft/arm/lithium-codegen-arm.cc

@@ -2621,11 +2621,8 @@ void LCodeGen::EmitVectorStoreICRegisters(T* instr) {

void LCodeGen::DoLoadGlobalGeneric(LLoadGlobalGeneric* instr) {

DCHECK(ToRegister(instr->context()).is(cp));

- DCHECK(ToRegister(instr->global_object())

- .is(LoadDescriptor::ReceiverRegister()));

DCHECK(ToRegister(instr->result()).is(r0));

- __ mov(LoadDescriptor::NameRegister(), Operand(instr->name()));

EmitVectorLoadICRegisters<LLoadGlobalGeneric>(instr);

Handle<Code> ic =

CodeFactory::LoadGlobalICInOptimizedCode(isolate(), instr->typeof_mode())

« no previous file with comments | « src/crankshaft/arm/lithium-arm.cc ('k') | src/crankshaft/arm64/lithium-arm64.h » ('j') | no next file with comments »