Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 2096653003: [ic] Don't pass receiver and name to LoadGlobalIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@store-name-in-metavector
Patch Set: Removed name parameter. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interface-descriptors.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1195 matching lines...) Expand 10 before | Expand all | Expand 10 after
1206 __ push(Immediate(var->name())); 1206 __ push(Immediate(var->name()));
1207 __ CallRuntime(Runtime::kThrowReferenceError); 1207 __ CallRuntime(Runtime::kThrowReferenceError);
1208 } 1208 }
1209 __ jmp(done); 1209 __ jmp(done);
1210 } 1210 }
1211 } 1211 }
1212 1212
1213 1213
1214 void FullCodeGenerator::EmitGlobalVariableLoad(VariableProxy* proxy, 1214 void FullCodeGenerator::EmitGlobalVariableLoad(VariableProxy* proxy,
1215 TypeofMode typeof_mode) { 1215 TypeofMode typeof_mode) {
1216 #ifdef DEBUG
1216 Variable* var = proxy->var(); 1217 Variable* var = proxy->var();
1217 DCHECK(var->IsUnallocatedOrGlobalSlot() || 1218 DCHECK(var->IsUnallocatedOrGlobalSlot() ||
1218 (var->IsLookupSlot() && var->mode() == DYNAMIC_GLOBAL)); 1219 (var->IsLookupSlot() && var->mode() == DYNAMIC_GLOBAL));
1219 __ mov(LoadDescriptor::ReceiverRegister(), NativeContextOperand()); 1220 #endif
1220 __ mov(LoadDescriptor::ReceiverRegister(), 1221 __ mov(LoadGlobalDescriptor::SlotRegister(),
1221 ContextOperand(LoadDescriptor::ReceiverRegister(),
1222 Context::EXTENSION_INDEX));
1223 __ mov(LoadDescriptor::NameRegister(), var->name());
1224 __ mov(LoadDescriptor::SlotRegister(),
1225 Immediate(SmiFromSlot(proxy->VariableFeedbackSlot()))); 1222 Immediate(SmiFromSlot(proxy->VariableFeedbackSlot())));
1226 CallLoadGlobalIC(typeof_mode); 1223 CallLoadGlobalIC(typeof_mode);
1227 } 1224 }
1228 1225
1229 1226
1230 void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy, 1227 void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy,
1231 TypeofMode typeof_mode) { 1228 TypeofMode typeof_mode) {
1232 SetExpressionPosition(proxy); 1229 SetExpressionPosition(proxy);
1233 PrepareForBailoutForId(proxy->BeforeId(), BailoutState::NO_REGISTERS); 1230 PrepareForBailoutForId(proxy->BeforeId(), BailoutState::NO_REGISTERS);
1234 Variable* var = proxy->var(); 1231 Variable* var = proxy->var();
(...skipping 2456 matching lines...) Expand 10 before | Expand all | Expand 10 after
3691 isolate->builtins()->OnStackReplacement()->entry(), 3688 isolate->builtins()->OnStackReplacement()->entry(),
3692 Assembler::target_address_at(call_target_address, unoptimized_code)); 3689 Assembler::target_address_at(call_target_address, unoptimized_code));
3693 return ON_STACK_REPLACEMENT; 3690 return ON_STACK_REPLACEMENT;
3694 } 3691 }
3695 3692
3696 3693
3697 } // namespace internal 3694 } // namespace internal
3698 } // namespace v8 3695 } // namespace v8
3699 3696
3700 #endif // V8_TARGET_ARCH_X87 3697 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interface-descriptors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698