Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2096653003: [ic] Don't pass receiver and name to LoadGlobalIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@store-name-in-metavector
Patch Set: Removed name parameter. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1270 matching lines...) Expand 10 before | Expand all | Expand 10 after
1281 __ push(a0); 1281 __ push(a0);
1282 __ CallRuntime(Runtime::kThrowReferenceError); 1282 __ CallRuntime(Runtime::kThrowReferenceError);
1283 } 1283 }
1284 __ Branch(done); 1284 __ Branch(done);
1285 } 1285 }
1286 } 1286 }
1287 1287
1288 1288
1289 void FullCodeGenerator::EmitGlobalVariableLoad(VariableProxy* proxy, 1289 void FullCodeGenerator::EmitGlobalVariableLoad(VariableProxy* proxy,
1290 TypeofMode typeof_mode) { 1290 TypeofMode typeof_mode) {
1291 #ifdef DEBUG
1291 Variable* var = proxy->var(); 1292 Variable* var = proxy->var();
1292 DCHECK(var->IsUnallocatedOrGlobalSlot() || 1293 DCHECK(var->IsUnallocatedOrGlobalSlot() ||
1293 (var->IsLookupSlot() && var->mode() == DYNAMIC_GLOBAL)); 1294 (var->IsLookupSlot() && var->mode() == DYNAMIC_GLOBAL));
1294 __ LoadGlobalObject(LoadDescriptor::ReceiverRegister()); 1295 #endif
1295 __ li(LoadDescriptor::NameRegister(), Operand(var->name())); 1296 __ li(LoadGlobalDescriptor::SlotRegister(),
1296 __ li(LoadDescriptor::SlotRegister(),
1297 Operand(SmiFromSlot(proxy->VariableFeedbackSlot()))); 1297 Operand(SmiFromSlot(proxy->VariableFeedbackSlot())));
1298 CallLoadGlobalIC(typeof_mode); 1298 CallLoadGlobalIC(typeof_mode);
1299 } 1299 }
1300 1300
1301 1301
1302 void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy, 1302 void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy,
1303 TypeofMode typeof_mode) { 1303 TypeofMode typeof_mode) {
1304 // Record position before possible IC call. 1304 // Record position before possible IC call.
1305 SetExpressionPosition(proxy); 1305 SetExpressionPosition(proxy);
1306 PrepareForBailoutForId(proxy->BeforeId(), BailoutState::NO_REGISTERS); 1306 PrepareForBailoutForId(proxy->BeforeId(), BailoutState::NO_REGISTERS);
(...skipping 2497 matching lines...) Expand 10 before | Expand all | Expand 10 after
3804 reinterpret_cast<uint32_t>( 3804 reinterpret_cast<uint32_t>(
3805 isolate->builtins()->OnStackReplacement()->entry())); 3805 isolate->builtins()->OnStackReplacement()->entry()));
3806 return ON_STACK_REPLACEMENT; 3806 return ON_STACK_REPLACEMENT;
3807 } 3807 }
3808 3808
3809 3809
3810 } // namespace internal 3810 } // namespace internal
3811 } // namespace v8 3811 } // namespace v8
3812 3812
3813 #endif // V8_TARGET_ARCH_MIPS 3813 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698