Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/crankshaft/x87/lithium-codegen-x87.cc

Issue 2096653003: [ic] Don't pass receiver and name to LoadGlobalIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@store-name-in-metavector
Patch Set: Removed name parameter. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/x64/lithium-x64.cc ('k') | src/crankshaft/x87/lithium-x87.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/crankshaft/x87/lithium-codegen-x87.h" 7 #include "src/crankshaft/x87/lithium-codegen-x87.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2683 matching lines...) Expand 10 before | Expand all | Expand 10 after
2694 Handle<TypeFeedbackVector> vector = instr->hydrogen()->feedback_vector(); 2694 Handle<TypeFeedbackVector> vector = instr->hydrogen()->feedback_vector();
2695 __ mov(vector_register, vector); 2695 __ mov(vector_register, vector);
2696 FeedbackVectorSlot slot = instr->hydrogen()->slot(); 2696 FeedbackVectorSlot slot = instr->hydrogen()->slot();
2697 int index = vector->GetIndex(slot); 2697 int index = vector->GetIndex(slot);
2698 __ mov(slot_register, Immediate(Smi::FromInt(index))); 2698 __ mov(slot_register, Immediate(Smi::FromInt(index)));
2699 } 2699 }
2700 2700
2701 2701
2702 void LCodeGen::DoLoadGlobalGeneric(LLoadGlobalGeneric* instr) { 2702 void LCodeGen::DoLoadGlobalGeneric(LLoadGlobalGeneric* instr) {
2703 DCHECK(ToRegister(instr->context()).is(esi)); 2703 DCHECK(ToRegister(instr->context()).is(esi));
2704 DCHECK(ToRegister(instr->global_object())
2705 .is(LoadDescriptor::ReceiverRegister()));
2706 DCHECK(ToRegister(instr->result()).is(eax)); 2704 DCHECK(ToRegister(instr->result()).is(eax));
2707 2705
2708 __ mov(LoadDescriptor::NameRegister(), instr->name());
2709 EmitVectorLoadICRegisters<LLoadGlobalGeneric>(instr); 2706 EmitVectorLoadICRegisters<LLoadGlobalGeneric>(instr);
2710 Handle<Code> ic = 2707 Handle<Code> ic =
2711 CodeFactory::LoadGlobalICInOptimizedCode(isolate(), instr->typeof_mode()) 2708 CodeFactory::LoadGlobalICInOptimizedCode(isolate(), instr->typeof_mode())
2712 .code(); 2709 .code();
2713 CallCode(ic, RelocInfo::CODE_TARGET, instr); 2710 CallCode(ic, RelocInfo::CODE_TARGET, instr);
2714 } 2711 }
2715 2712
2716 2713
2717 void LCodeGen::DoLoadContextSlot(LLoadContextSlot* instr) { 2714 void LCodeGen::DoLoadContextSlot(LLoadContextSlot* instr) {
2718 Register context = ToRegister(instr->context()); 2715 Register context = ToRegister(instr->context());
(...skipping 3144 matching lines...) Expand 10 before | Expand all | Expand 10 after
5863 __ bind(deferred->exit()); 5860 __ bind(deferred->exit());
5864 __ bind(&done); 5861 __ bind(&done);
5865 } 5862 }
5866 5863
5867 #undef __ 5864 #undef __
5868 5865
5869 } // namespace internal 5866 } // namespace internal
5870 } // namespace v8 5867 } // namespace v8
5871 5868
5872 #endif // V8_TARGET_ARCH_X87 5869 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/crankshaft/x64/lithium-x64.cc ('k') | src/crankshaft/x87/lithium-x87.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698