Rework PerformanceTracker to make it usable with WebRTC

remoting/client/software_video_renderer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/software_video_renderer.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/callback_helpers.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/single_thread_task_runner.h"
 #include "base/task_runner_util.h"
 #include "remoting/base/util.h"
 #include "remoting/codec/video_decoder.h"
 #include "remoting/codec/video_decoder_verbatim.h"
 #include "remoting/codec/video_decoder_vpx.h"
 #include "remoting/proto/video.pb.h"
 #include "remoting/protocol/frame_consumer.h"
+#include "remoting/protocol/frame_stats.h"
+#include "remoting/protocol/performance_tracker.h"
 #include "remoting/protocol/session_config.h"
 #include "third_party/libyuv/include/libyuv/convert_argb.h"
 #include "third_party/webrtc/modules/desktop_capture/desktop_frame.h"
 
 using remoting::protocol::ChannelConfig;
 using remoting::protocol::SessionConfig;
 
 namespace remoting {
 
 namespace {
@@ skipping 83 matching lines @@
   return consumer_;
 }
 
 void SoftwareVideoRenderer::ProcessVideoPacket(
     std::unique_ptr<VideoPacket> packet,
     const base::Closure& done) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   base::ScopedClosureRunner done_runner(done);
 
-  if (perf_tracker_)
-    perf_tracker_->RecordVideoPacketStats(*packet);
+  std::unique_ptr<protocol::FrameStats> frame_stats(new protocol::FrameStats(
+      protocol::FrameStats::GetForVideoPacket(*packet)));
 
   // If the video packet is empty then drop it. Empty packets are used to
   // maintain activity on the network.

[Jamie, 2016/06/24 23:53:21]

We are no longer just dropping the packet. Add a comment explaining why we
should record the stats for empty packets?

[Sergey Ulanov, 2016/06/25 05:34:03]

Done.

   if (!packet->has_data() || packet->data().size() == 0) {
+    if (perf_tracker_)
+      perf_tracker_->RecordVideoFrameStats(*frame_stats);
     return;
   }
 
   if (packet->format().has_screen_width() &&
       packet->format().has_screen_height()) {
     source_size_.set(packet->format().screen_width(),
                      packet->format().screen_height());
   }
 
   if (packet->format().has_x_dpi() && packet->format().has_y_dpi()) {
     webrtc::DesktopVector source_dpi(packet->format().x_dpi(),
                                      packet->format().y_dpi());
     if (!source_dpi.equals(source_dpi_)) {
       source_dpi_ = source_dpi;
     }
   }
 
   if (source_size_.is_empty()) {
     LOG(ERROR) << "Received VideoPacket with unknown size.";
     return;
   }
 
   std::unique_ptr<webrtc::DesktopFrame> frame =
       consumer_->AllocateFrame(source_size_);
   frame->set_dpi(source_dpi_);
 
-  int32_t frame_id = packet->frame_id();
   base::PostTaskAndReplyWithResult(
       decode_task_runner_.get(), FROM_HERE,
       base::Bind(&DoDecodeFrame, decoder_.get(), base::Passed(&packet),
                  base::Passed(&frame)),
       base::Bind(&SoftwareVideoRenderer::RenderFrame,
-                 weak_factory_.GetWeakPtr(), frame_id, done_runner.Release()));
+                 weak_factory_.GetWeakPtr(), base::Passed(&frame_stats),
+                 done_runner.Release()));
 }
 
 void SoftwareVideoRenderer::RenderFrame(
-    int32_t frame_id,
+    std::unique_ptr<protocol::FrameStats> stats,
     const base::Closure& done,
     std::unique_ptr<webrtc::DesktopFrame> frame) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
-  if (perf_tracker_)
-    perf_tracker_->OnFrameDecoded(frame_id);
+  stats->time_decoded = base::TimeTicks::Now();
 
   if (!frame) {
     if (!done.is_null())
       done.Run();
     return;
   }
 
-  consumer_->DrawFrame(std::move(frame),
-                       base::Bind(&SoftwareVideoRenderer::OnFrameRendered,
-                                  weak_factory_.GetWeakPtr(), frame_id, done));
+  consumer_->DrawFrame(
+      std::move(frame),
+      base::Bind(&SoftwareVideoRenderer::OnFrameRendered,
+                 weak_factory_.GetWeakPtr(), base::Passed(&stats), done));
 }
 
-void SoftwareVideoRenderer::OnFrameRendered(int32_t frame_id,
-                                            const base::Closure& done) {
+void SoftwareVideoRenderer::OnFrameRendered(
+    std::unique_ptr<protocol::FrameStats> stats,
+    const base::Closure& done) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
+  stats->time_rendered = base::TimeTicks::Now();
   if (perf_tracker_)
-    perf_tracker_->OnFramePainted(frame_id);
+    perf_tracker_->RecordVideoFrameStats(*stats);
 
   if (!done.is_null())
     done.Run();
 }
 
 }  // namespace remoting