content/browser/devtools/protocol/emulation_handler.h - Issue 2096633002: Adds scroll position/scale emulation to DevTools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/emulation_handler.h

Issue 2096633002: Adds scroll position/scale emulation to DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes issues with visual viewport scroll override, mainFrameSize on scale override, clamps position… Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/emulation_handler.h

diff --git a/content/browser/devtools/protocol/emulation_handler.h b/content/browser/devtools/protocol/emulation_handler.h

index e61862e66a7492a3697a5ebef1cad6c6fc01eacd..93e210ab12de10f5103d95ce52f81bcb818f4cac 100644

--- a/content/browser/devtools/protocol/emulation_handler.h

+++ b/content/browser/devtools/protocol/emulation_handler.h

@@ -52,7 +52,14 @@ class EmulationHandler {

const int* screen_height,

const int* position_x,

const int* position_y,

- const std::unique_ptr<base::DictionaryValue>& screen_orientation);

+ const std::unique_ptr<base::DictionaryValue>& screen_orientation,

+ const int* scroll_position_x,

+ const int* scroll_position_y,

+ const int* visual_viewport_width,

+ const int* visual_viewport_height,

+ const double* visual_viewport_position_x,

+ const double* visual_viewport_position_y,

+ const double* visual_viewport_scale);

Response ClearDeviceMetricsOverride();

private: