Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

Issue 2096633002: Adds scroll position/scale emulation to DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync, patch in 2169483002 (+ regression test), add DevTools tests. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
index b44a02ca9f61dc2195393455c3dee721d9b18933..0a8af6fca6bb4fb7e09de15f16b6c1ead882e0d6 100644
--- a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
@@ -596,11 +596,11 @@ void PaintLayerCompositor::frameViewDidScroll()
scrollingCoordinatorHandlesOffset = scrollingCoordinator->scrollableAreaScrollLayerDidChange(frameView);
}
- // Scroll position = scroll minimum + scroll offset. Adjust the layer's
+ // Scroll position = scroll origin + scroll offset. Adjust the layer's
// position to handle whatever the scroll coordinator isn't handling.
- // The minimum scroll position is non-zero for RTL pages with overflow.
+ // The scroll origin is non-zero for RTL pages with overflow.
if (scrollingCoordinatorHandlesOffset)
- m_scrollLayer->setPosition(-frameView->minimumScrollPosition());
+ m_scrollLayer->setPosition(frameView->scrollOrigin());
else
m_scrollLayer->setPosition(-scrollPosition);

Powered by Google App Engine
This is Rietveld 408576698