Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 209663007: Fix bug in scrollParent (Closed)

Created:
6 years, 9 months ago by Ian Vollick
Modified:
6 years, 9 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Fix bug in scrollParent We were early'ing out, but not calling cache->setScrollParent. The result: the cache thought it was dirty, but it wasn't. This CL fixes that. BUG=TBD Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M Source/core/rendering/RenderLayer.cpp View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hartmanng
lgtm
6 years, 9 months ago (2014-03-24 15:56:39 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-24 16:53:00 UTC) #2
Ian Vollick
The CQ bit was checked by vollick@chromium.org
6 years, 9 months ago (2014-03-24 16:53:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/209663007/1
6 years, 9 months ago (2014-03-24 16:53:31 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 17:54:06 UTC) #5
Message was sent while issue was closed.
Change committed as 169870

Powered by Google App Engine
This is Rietveld 408576698