Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 209663006: [fsp] Simplify ID of provided file systems. (Closed)

Created:
6 years, 9 months ago by mtomasz
Modified:
6 years, 9 months ago
Reviewers:
benwells, satorux1
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[fsp] Simplify ID of provided file systems. Previously, the ID was very lenghty, being same as the mount point name. Also, it contained the extension id, which was too much. To makes things simple, the ID has been changed to an int only, which is consistent with setTimeout/setInterval as well as upcoming request's id, which are just positive numbers. TEST=unit_tests, browser_tests BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259842

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Messages

Total messages: 7 (0 generated)
mtomasz
This CL depends on 192573002. @satorux: PTAL. @benwells: PTAL at IDL. Thanks.
6 years, 9 months ago (2014-03-24 06:40:18 UTC) #1
benwells
lgtm
6 years, 9 months ago (2014-03-24 21:31:47 UTC) #2
satorux1
lgtm https://codereview.chromium.org/209663006/diff/1/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc File chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc (right): https://codereview.chromium.org/209663006/diff/1/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc#newcode57 chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc:57: // If the |file_system_id| is empty, then it ...
6 years, 9 months ago (2014-03-26 07:58:45 UTC) #3
mtomasz
https://codereview.chromium.org/209663006/diff/1/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc File chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc (right): https://codereview.chromium.org/209663006/diff/1/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc#newcode57 chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc:57: // If the |file_system_id| is empty, then it means ...
6 years, 9 months ago (2014-03-26 09:30:15 UTC) #4
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 9 months ago (2014-03-27 08:04:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/209663006/70001
6 years, 9 months ago (2014-03-27 08:05:20 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 12:04:13 UTC) #7
Message was sent while issue was closed.
Change committed as 259842

Powered by Google App Engine
This is Rietveld 408576698