Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: Source/bindings/scripts/compute_interfaces_info.py

Issue 209663005: Add back [ImplementedInBaseClass] IDL extended attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/IDLExtendedAttributes.txt ('k') | Source/bindings/scripts/interface_dependency_resolver.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/compute_interfaces_info.py
diff --git a/Source/bindings/scripts/compute_interfaces_info.py b/Source/bindings/scripts/compute_interfaces_info.py
index 8d425bf0bc7fdc4e4dde2fcb3e02edeae79d90ec..5084d903111502a87044c4d88fa1f4b016d981dd 100755
--- a/Source/bindings/scripts/compute_interfaces_info.py
+++ b/Source/bindings/scripts/compute_interfaces_info.py
@@ -163,7 +163,9 @@ def compute_individual_info(idl_filename):
implemented_as = extended_attributes.get('ImplementedAs')
# FIXME: remove [NoHeader] once switch to Python
this_include_path = (include_path(idl_filename, implemented_as)
- if 'NoHeader' not in extended_attributes else None)
+ if ('ImplementedInBaseClass' not in extended_attributes
+ and 'NoHeader' not in extended_attributes)
haraken 2014/03/24 05:51:32 Can you remove NoHeader in the near future?
Nils Barth (inactive) 2014/03/24 06:19:45 Yes; will do in separate CL to keep this one simpl
+ else None)
# Handle partial interfaces
partial_interface_name = get_partial_interface_name_from_idl(idl_file_contents)
« no previous file with comments | « Source/bindings/IDLExtendedAttributes.txt ('k') | Source/bindings/scripts/interface_dependency_resolver.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698