Issue 209663005: Add back [ImplementedInBaseClass] IDL extended attribute

Issue 209663005: Add back [ImplementedInBaseClass] IDL extended attribute (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)

Modified:
6 years, 9 months ago

Reviewers:
haraken, Inactive

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, bajones

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add back [ImplementedInBaseClass] IDL extended attribute Originally [LegacyImplementedInBaseClass] was intended to be short-term, as the name suggests, for some refactoring. However, for more complex cases of 'implements' usage, the requirements that 'implements' puts on C++ implementation makes it an ugly mess. Thus allowing implementation in base class seems useful long-term, so re-introducing. Per: WebGLRenderingContextBase https://codereview.chromium.org/205243013/ Documentation: http://www.chromium.org/blink/webidl/blink-idl-extended-attributes#TOC-ImplementedInBaseClass-i- Compare earlier CL removing this: Remove support for [LegacyImplementedInBaseClass] IDL extended attribute https://codereview.chromium.org/169273002/ R=haraken BUG=344224 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169830

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -5 lines)			Patch
M	Source/bindings/IDLExtendedAttributes.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/scripts/compute_interfaces_info.py	View	1 chunk	+3 lines, -1 line	2 comments	Download
M	Source/bindings/scripts/interface_dependency_resolver.py	View	1 chunk	+6 lines, -4 lines	0 comments	Download
A	Source/bindings/tests/idls/TestImplements3.idl	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	Source/bindings/tests/idls/TestInterfacePython.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestInterfacePython.cpp	View	6 chunks	+81 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/209663005/diff/1/Source/bindings/scripts/compute_interfaces_info.py File Source/bindings/scripts/compute_interfaces_info.py (right): https://codereview.chromium.org/209663005/diff/1/Source/bindings/scripts/compute_interfaces_info.py#newcode167 Source/bindings/scripts/compute_interfaces_info.py:167: and 'NoHeader' not in extended_attributes) Can you remove ...

6 years, 9 months ago (2014-03-24 05:51:31 UTC) #2

Nils Barth (inactive)

https://codereview.chromium.org/209663005/diff/1/Source/bindings/scripts/compute_interfaces_info.py File Source/bindings/scripts/compute_interfaces_info.py (right): https://codereview.chromium.org/209663005/diff/1/Source/bindings/scripts/compute_interfaces_info.py#newcode167 Source/bindings/scripts/compute_interfaces_info.py:167: and 'NoHeader' not in extended_attributes) On 2014/03/24 05:51:32, haraken ...

6 years, 9 months ago (2014-03-24 06:19:45 UTC) #3

Nils Barth (inactive)

The CQ bit was checked by nbarth@chromium.org

6 years, 9 months ago (2014-03-24 06:19:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209663005/1

6 years, 9 months ago (2014-03-24 06:19:51 UTC) #5

Message was sent while issue was closed.

Change committed as 169830

Expand Messages | Collapse Messages