Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2096613002: Reland of add a Chrome builder to the CQ (Closed)

Created:
4 years, 6 months ago by rmistry
Modified:
4 years, 6 months ago
Reviewers:
mtklein, mtklein_C, reed1
CC:
reviews_skia.org, borenet
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2087913003/ ) Reason for revert: Will watch this after it is in. Original issue's description: > Revert of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2085333002/ ) > > Reason for revert: > Reverting due to purple trybots in https://codereview.chromium.org/2087343002/ > > We will have to investigate.. > > Original issue's description: > > add a Chrome builder to the CQ > > > > This appears to be the fastest Chrome builder, averaging 8-9 minutes. > > > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002 > > > > Committed: https://skia.googlesource.com/skia/+/cb4efa90ab5f6ea7cf5e0f44aec6f4e6418aad3d > > TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/1afb8f8965b0549525c1ad8d8baa885ccdb48f6d TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9afccaaf8e5247095d1748059520733f289597e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M infra/branch-config/cq.cfg View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmistry
Created Reland of add a Chrome builder to the CQ
4 years, 6 months ago (2016-06-23 11:16:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096613002/1
4 years, 6 months ago (2016-06-23 11:16:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9afccaaf8e5247095d1748059520733f289597e9
4 years, 6 months ago (2016-06-23 11:16:44 UTC) #5
rmistry
4 years, 6 months ago (2016-06-23 11:54:30 UTC) #6
Message was sent while issue was closed.
I tested this with: https://codereview.chromium.org/2098443003#


Looking at logs of mac_chromium_compile_dbg_ng :


===Running apply_issue --root_dir src/third_party/skia --issue 2098443003
--server https://codereview.chromium.org --force --ignore_deps -v -v --no-auth
--patchset 1 (attempt #1)===
In directory: /b/build/slave/mac/build
Connecting to https://codereview.chromium.org
DEBUG    rietveld( 402): POSTing to /api/2098443003, args {'payload': None,
'timeout': 15}.
DEBUG    rietveld( 419): /api/2098443003
DEBUG    rietveld( 402): POSTing to
/2098443003/patchset/1/get_depends_on_patchset, args {'timeout': 15, 'payload':
'---M-A-G-I-C---B-O-U-N-D-A-R-Y-0---\r\n', 'content_type': 'multipart/form-data;
boundary=-M-A-G-I-C---B-O-U-N-D-A-R-Y-0-'}.
DEBUG    rietveld( 419): /2098443003/patchset/1/get_depends_on_patchset
Downloading patch from https://codereview.chromium.org/2098443003/#ps1
DEBUG    rietveld( 402): POSTing to /api/2098443003/1, args {'payload': None,
'timeout': 15}.
DEBUG    rietveld( 419): /api/2098443003/1
DEBUG    rietveld( 133): whitespace.txt
DEBUG    rietveld( 402): POSTing to /download/issue2098443003_1_10001.diff, args
{'payload': None, 'timeout': 15}.
DEBUG    rietveld( 419): /download/issue2098443003_1_10001.diff
      whitespace.txt

Applying the patch from https://codereview.chromium.org/2098443003/#ps1
DEBUG subprocess2( 215): git apply --index -3 -p1 --verbose; 
cwd=/b/build/slave/mac/build/src/third_party/skia
whitespace.txt
  Checking patch whitespace.txt...
  Applied patch whitespace.txt cleanly.



Looks like it is doing the right thing. Yay!

Powered by Google App Engine
This is Rietveld 408576698