Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2096573003: Make callers of FromUTC(Local)Exploded in crypto/ use new time API. (Closed)

Created:
4 years, 6 months ago by maksims (do not use this acc)
Modified:
4 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make callers of FromUTC(Local)Exploded in crypto/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601900 Committed: https://crrev.com/5ae45866acc94635f19188f535d813a7c9c9488d Cr-Commit-Position: refs/heads/master@{#402732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M crypto/nss_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096573003/1
4 years, 6 months ago (2016-06-23 07:53:45 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 08:36:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096573003/1
4 years, 5 months ago (2016-06-28 09:41:53 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 10:17:11 UTC) #10
maksims (do not use this acc)
please take a look
4 years, 5 months ago (2016-06-28 10:26:06 UTC) #11
Ryan Sleevi
lgtm
4 years, 5 months ago (2016-06-28 17:14:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096573003/1
4 years, 5 months ago (2016-06-29 05:06:03 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 05:14:42 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 05:16:34 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ae45866acc94635f19188f535d813a7c9c9488d
Cr-Commit-Position: refs/heads/master@{#402732}

Powered by Google App Engine
This is Rietveld 408576698