Issue 209653003: Introduce HeapSnapshotItem interface

Issue 209653003: Introduce HeapSnapshotItem interface (Closed)

Created:
6 years, 9 months ago by yurys

Modified:
6 years, 9 months ago

Reviewers:
alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Introduce HeapSnapshotItem interface The interface describes common part of nodes as well as containment and retainment edges. It used to iterate over the elements and serialize them. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169845

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -43 lines)			Patch
	M	Source/devtools/front_end/HeapSnapshot.js	View	1	15 chunks	+57 lines, -43 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

alph

lgtm https://codereview.chromium.org/209653003/diff/1/Source/devtools/front_end/HeapSnapshot.js File Source/devtools/front_end/HeapSnapshot.js (right): https://codereview.chromium.org/209653003/diff/1/Source/devtools/front_end/HeapSnapshot.js#newcode146 Source/devtools/front_end/HeapSnapshot.js:146: WebInspector.HeapSnapshotItem = function() { } Plz move the ...

6 years, 9 months ago (2014-03-24 10:09:28 UTC) #2

yurys

https://codereview.chromium.org/209653003/diff/1/Source/devtools/front_end/HeapSnapshot.js File Source/devtools/front_end/HeapSnapshot.js (right): https://codereview.chromium.org/209653003/diff/1/Source/devtools/front_end/HeapSnapshot.js#newcode146 Source/devtools/front_end/HeapSnapshot.js:146: WebInspector.HeapSnapshotItem = function() { } On 2014/03/24 10:09:29, alph ...

6 years, 9 months ago (2014-03-24 12:05:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/209653003/20001

6 years, 9 months ago (2014-03-24 12:13:03 UTC) #5

Message was sent while issue was closed.

Change committed as 169845

Expand Messages | Collapse Messages