content/renderer/android/synchronous_compositor_output_surface.cc - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/android/synchronous_compositor_output_surface.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/android/synchronous_compositor_output_surface.cc

diff --git a/content/renderer/android/synchronous_compositor_output_surface.cc b/content/renderer/android/synchronous_compositor_output_surface.cc

index 2c0d349104bcdae9b6a74a3f89acdf85dc074a67..9ee71b110e07cbb4d9786c87f15688acfa0b937f 100644

--- a/content/renderer/android/synchronous_compositor_output_surface.cc

+++ b/content/renderer/android/synchronous_compositor_output_surface.cc

@@ -155,11 +155,11 @@ void SynchronousCompositorOutputSurface::Reshape(const gfx::Size& size,

}

void SynchronousCompositorOutputSurface::SwapBuffers(

- cc::CompositorFrame* frame) {

+ cc::CompositorFrame frame) {

DCHECK(CalledOnValidThread());

DCHECK(sync_client_);

if (!fallback_tick_running_) {

- sync_client_->SwapBuffers(output_surface_id_, frame);

+ sync_client_->SwapBuffers(output_surface_id_, std::move(frame));

DeliverMessages();

}

client_->DidSwapBuffers();