Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dana's nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/compositor_impl_android.cc
diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc
index fa3b000368fcfb135329d92f49f40dcae4b133e9..0d657568f64e5d321b4eca5301bfa05082451721 100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -174,13 +174,13 @@ class OutputSurfaceWithoutParent : public cc::OutputSurface {
~OutputSurfaceWithoutParent() override = default;
- void SwapBuffers(cc::CompositorFrame* frame) override {
- GetCommandBufferProxy()->SetLatencyInfo(frame->metadata.latency_info);
- if (frame->gl_frame_data->sub_buffer_rect.IsEmpty()) {
+ void SwapBuffers(cc::CompositorFrame frame) override {
+ GetCommandBufferProxy()->SetLatencyInfo(frame.metadata.latency_info);
+ if (frame.gl_frame_data->sub_buffer_rect.IsEmpty()) {
context_provider_->ContextSupport()->CommitOverlayPlanes();
} else {
- DCHECK(frame->gl_frame_data->sub_buffer_rect ==
- gfx::Rect(frame->gl_frame_data->size));
+ DCHECK(frame.gl_frame_data->sub_buffer_rect ==
+ gfx::Rect(frame.gl_frame_data->size));
context_provider_->ContextSupport()->Swap();
}
client_->DidSwapBuffers();
@@ -264,7 +264,7 @@ class VulkanOutputSurface : public cc::OutputSurface {
return true;
}
- void SwapBuffers(cc::CompositorFrame* frame) override {
+ void SwapBuffers(cc::CompositorFrame frame) override {
surface_->SwapBuffers();
PostSwapBuffersComplete();
client_->DidSwapBuffers();

Powered by Google App Engine
This is Rietveld 408576698