content/browser/compositor/reflector_impl_unittest.cc - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/reflector_impl_unittest.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/compositor/reflector_impl_unittest.cc

diff --git a/content/browser/compositor/reflector_impl_unittest.cc b/content/browser/compositor/reflector_impl_unittest.cc

index ca0535c06f6516871ddfcfd1ac016914277ebed1..0b7e22342ca0e15260a431ed6bbbd11452df22b3 100644

--- a/content/browser/compositor/reflector_impl_unittest.cc

+++ b/content/browser/compositor/reflector_impl_unittest.cc

@@ -6,6 +6,7 @@

#include "base/run_loop.h"

#include "base/single_thread_task_runner.h"

#include "build/build_config.h"

+#include "cc/output/compositor_frame.h"

#include "cc/scheduler/begin_frame_source.h"

#include "cc/scheduler/delay_based_time_source.h"

#include "cc/test/fake_output_surface_client.h"

@@ -88,7 +89,7 @@ class TestOutputSurface : public BrowserCompositorOutputSurface {

void SetFlip(bool flip) { capabilities_.flipped_output_surface = flip; }

- void SwapBuffers(cc::CompositorFrame* frame) override {}

+ void SwapBuffers(cc::CompositorFrame frame) override {}

uint32_t GetFramebufferCopyTextureFormat() override { return GL_RGB; }

void OnReflectorChanged() override {