Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: content/browser/android/synchronous_compositor_host.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dana's nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/synchronous_compositor_host.cc
diff --git a/content/browser/android/synchronous_compositor_host.cc b/content/browser/android/synchronous_compositor_host.cc
index a8a4de02f76bbb1eb773dd20c97c46ff2d249c9a..5bd7165ca658e9934e30effded85d2b9802c0a79 100644
--- a/content/browser/android/synchronous_compositor_host.cc
+++ b/content/browser/android/synchronous_compositor_host.cc
@@ -119,14 +119,14 @@ SynchronousCompositor::Frame SynchronousCompositorHost::DemandDrawHw(
frame.frame.reset();
}
if (frame.frame) {
- UpdateFrameMetaData(frame.frame->metadata);
+ UpdateFrameMetaData(frame.frame->metadata.Clone());
}
return frame;
}
void SynchronousCompositorHost::UpdateFrameMetaData(
- const cc::CompositorFrameMetadata& frame_metadata) {
- rwhva_->SynchronousFrameMetadata(frame_metadata);
+ cc::CompositorFrameMetadata frame_metadata) {
+ rwhva_->SynchronousFrameMetadata(std::move(frame_metadata));
}
namespace {
@@ -161,7 +161,7 @@ bool SynchronousCompositorHost::DemandDrawSwInProc(SkCanvas* canvas) {
if (!success)
return false;
ProcessCommonParams(common_renderer_params);
- UpdateFrameMetaData(frame->metadata);
+ UpdateFrameMetaData(std::move(frame->metadata));
return true;
}
@@ -227,7 +227,7 @@ bool SynchronousCompositorHost::DemandDrawSw(SkCanvas* canvas) {
return false;
ProcessCommonParams(common_renderer_params);
- UpdateFrameMetaData(frame->metadata);
+ UpdateFrameMetaData(std::move(frame->metadata));
SkBitmap bitmap;
if (!bitmap.installPixels(info, software_draw_shm_->shm.memory(), stride))

Powered by Google App Engine
This is Rietveld 408576698