blimp/client/feature/compositor/blimp_output_surface.cc - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/feature/compositor/blimp_output_surface.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/feature/compositor/blimp_output_surface.cc

diff --git a/blimp/client/feature/compositor/blimp_output_surface.cc b/blimp/client/feature/compositor/blimp_output_surface.cc

index 092b712bdd6adc32b6ae759e672cb9d389c7e887..e7f905f2c216e5574753fbe73e8c0d0b23b795f5 100644

--- a/blimp/client/feature/compositor/blimp_output_surface.cc

+++ b/blimp/client/feature/compositor/blimp_output_surface.cc

@@ -7,6 +7,7 @@

#include "base/bind.h"

#include "base/message_loop/message_loop.h"

#include "blimp/client/feature/compositor/blimp_context_provider.h"

+#include "cc/output/compositor_frame.h"

#include "cc/output/output_surface_client.h"

#include "gpu/command_buffer/client/context_support.h"

@@ -19,7 +20,7 @@ BlimpOutputSurface::BlimpOutputSurface(

BlimpOutputSurface::~BlimpOutputSurface() {}

-void BlimpOutputSurface::SwapBuffers(cc::CompositorFrame* frame) {

+void BlimpOutputSurface::SwapBuffers(cc::CompositorFrame frame) {

// See cc::OutputSurface::SwapBuffers() comment for details.

context_provider_->ContextSupport()->Swap();

client_->DidSwapBuffers();