content/browser/devtools/protocol/page_handler.h - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/page_handler.h

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/page_handler.h

diff --git a/content/browser/devtools/protocol/page_handler.h b/content/browser/devtools/protocol/page_handler.h

index 6dbca0a58b44ff90f96cc45683d2bd3eac863fa5..4c750ea0b745714b7c82a2dcaa51003bcec09ae9 100644

--- a/content/browser/devtools/protocol/page_handler.h

+++ b/content/browser/devtools/protocol/page_handler.h

@@ -39,9 +39,9 @@ class PageHandler : public NotificationObserver {

void SetRenderFrameHost(RenderFrameHostImpl* host);

void SetClient(std::unique_ptr<Client> client);

void Detached();

- void OnSwapCompositorFrame(const cc::CompositorFrameMetadata& frame_metadata);

- void OnSynchronousSwapCompositorFrame(const cc::CompositorFrameMetadata&

- frame_metadata);

+ void OnSwapCompositorFrame(cc::CompositorFrameMetadata frame_metadata);

+ void OnSynchronousSwapCompositorFrame(

+ cc::CompositorFrameMetadata frame_metadata);

void DidAttachInterstitialPage();

void DidDetachInterstitialPage();

bool screencast_enabled() const { return enabled_ && screencast_enabled_; }