components/mus/public/cpp/surfaces/surfaces_type_converters.cc - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/cpp/surfaces/surfaces_type_converters.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/mus/public/cpp/surfaces/surfaces_type_converters.cc

diff --git a/components/mus/public/cpp/surfaces/surfaces_type_converters.cc b/components/mus/public/cpp/surfaces/surfaces_type_converters.cc

index 311fbad50bac30565295f44108748b0256c9cb4d..18fd265848f46572fa2772757051e8add5b1fb76 100644

--- a/components/mus/public/cpp/surfaces/surfaces_type_converters.cc

+++ b/components/mus/public/cpp/surfaces/surfaces_type_converters.cc

@@ -39,7 +39,7 @@ TypeConverter<CompositorFramePtr, cc::CompositorFrame>::Convert(

cc::DelegatedFrameData* frame_data = input.delegated_frame_data.get();

frame->resources =

mojo::Array<cc::TransferableResource>(frame_data->resource_list);

- frame->metadata = input.metadata;

+ frame->metadata = input.metadata.Clone();

const cc::RenderPassList& pass_list = frame_data->render_pass_list;

std::vector<std::unique_ptr<cc::RenderPass>> copy;

cc::RenderPass::CopyAll(pass_list, &copy);