Make cc::CompositorFrames movable [Part 1 of 2]

content/browser/devtools/protocol/page_handler.cc

Index: content/browser/devtools/protocol/page_handler.cc
diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc
index d472554b9e3ce1f415166559a8743ef171160182..068faa18698a06d0cefc1374e27cd01e05b34a85 100644
--- a/content/browser/devtools/protocol/page_handler.cc
+++ b/content/browser/devtools/protocol/page_handler.cc
@@ -146,7 +146,7 @@ void PageHandler::Detached() {
 
 void PageHandler::OnSwapCompositorFrame(
     const cc::CompositorFrameMetadata& frame_metadata) {
-  last_compositor_frame_metadata_ = frame_metadata;
+  last_compositor_frame_metadata_ = cc::CompositorFrameMetadata(frame_metadata);

[danakj, 2016/06/24 18:35:11]

dittos

[Fady Samuel, 2016/06/24 20:00:24]

Done.

   has_compositor_frame_metadata_ = true;
 
   if (screencast_enabled_)
@@ -156,9 +156,11 @@ void PageHandler::OnSwapCompositorFrame(
 
 void PageHandler::OnSynchronousSwapCompositorFrame(
     const cc::CompositorFrameMetadata& frame_metadata) {
-  last_compositor_frame_metadata_ = has_compositor_frame_metadata_ ?
-      next_compositor_frame_metadata_ : frame_metadata;
-  next_compositor_frame_metadata_ = frame_metadata;
+  last_compositor_frame_metadata_ =
+      has_compositor_frame_metadata_
+          ? cc::CompositorFrameMetadata(next_compositor_frame_metadata_)

[danakj, 2016/06/24 18:35:11]

dittos

[Fady Samuel, 2016/06/24 20:00:24]

Done.

+          : cc::CompositorFrameMetadata(frame_metadata);
+  next_compositor_frame_metadata_ = cc::CompositorFrameMetadata(frame_metadata);

[danakj, 2016/06/24 18:35:11]

A copy needs to be made here tho, so if you make it move-only you'll need a
Clone() method or something for this.

[Fady Samuel, 2016/06/24 20:00:24]

I made the above Clone() and using std::move on htis.

   has_compositor_frame_metadata_ = true;
 
   if (screencast_enabled_)