cc/output/software_renderer.cc - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/software_renderer.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make CompositorFrameMetadata movable Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/software_renderer.cc

diff --git a/cc/output/software_renderer.cc b/cc/output/software_renderer.cc

index 13d13418b200149d5245614386e93e7c6cac619e..d1a1ced018a41cf7e3de642280037b48b900adf5 100644

--- a/cc/output/software_renderer.cc

+++ b/cc/output/software_renderer.cc

@@ -112,8 +112,8 @@ void SoftwareRenderer::FinishDrawingFrame(DrawingFrame* frame) {

void SoftwareRenderer::SwapBuffers(const CompositorFrameMetadata& metadata) {

TRACE_EVENT0("cc,benchmark", "SoftwareRenderer::SwapBuffers");

CompositorFrame compositor_frame;

- compositor_frame.metadata = metadata;

- output_surface_->SwapBuffers(&compositor_frame);

+ compositor_frame.metadata = CompositorFrameMetadata(metadata);

+ output_surface_->SwapBuffers(std::move(compositor_frame));

}

bool SoftwareRenderer::FlippedFramebuffer(const DrawingFrame* frame) const {