Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make CompositorFrameMetadata movable Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/browser_view_renderer.cc
diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc
index ef2418d081cba509ca391bc3380b237d279025db..7e22619510673a046707a4d5fcde0fd0c3a61f22 100644
--- a/android_webview/browser/browser_view_renderer.cc
+++ b/android_webview/browser/browser_view_renderer.cc
@@ -247,14 +247,14 @@ bool BrowserViewRenderer::OnDrawHardware() {
clip,
viewport_rect_for_tile_priority,
transform_for_tile_priority);
- if (!frame.frame.get()) {
+ if (!frame.frame) {
TRACE_EVENT_INSTANT0("android_webview", "NoNewFrame",
TRACE_EVENT_SCOPE_THREAD);
return current_compositor_frame_consumer_->HasFrameOnUI();
}
std::unique_ptr<ChildFrame> child_frame = base::WrapUnique(new ChildFrame(
- frame.output_surface_id, std::move(frame.frame), compositor_id_,
+ frame.output_surface_id, std::move(*frame.frame), compositor_id_,
viewport_rect_for_tile_priority.IsEmpty(), transform_for_tile_priority,
offscreen_pre_raster_, external_draw_constraints_.is_layer));
@@ -293,7 +293,7 @@ void BrowserViewRenderer::RemoveCompositorFrameConsumer(
void BrowserViewRenderer::ReturnUnusedResource(
std::unique_ptr<ChildFrame> child_frame) {
- if (!child_frame.get() || !child_frame->frame.get())
+ if (!child_frame.get() || !child_frame->frame)
return;
cc::CompositorFrameAck frame_ack;
« no previous file with comments | « no previous file | android_webview/browser/browser_view_renderer_unittest.cc » ('j') | cc/output/delegating_renderer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698