cc/surfaces/surfaces_pixeltest.cc - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Unified Diff: cc/surfaces/surfaces_pixeltest.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix reflector Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/surfaces/surfaces_pixeltest.cc

diff --git a/cc/surfaces/surfaces_pixeltest.cc b/cc/surfaces/surfaces_pixeltest.cc

index 9af4ed93e523955b5d6b0fa0a48624d2eb6c08b9..bba9e44b2b3bc972e86a362f0122b9dd3b729f1a 100644

--- a/cc/surfaces/surfaces_pixeltest.cc

+++ b/cc/surfaces/surfaces_pixeltest.cc

@@ -77,7 +77,7 @@ TEST_F(SurfacesPixelTest, DrawSimpleFrame) {

new DelegatedFrameData);

delegated_frame_data->render_pass_list.push_back(std::move(pass));

- std::unique_ptr<CompositorFrame> root_frame(new CompositorFrame);

+ std::unique_ptr<CompositorFrame> root_frame(CompositorFrame::Create());

root_frame->delegated_frame_data = std::move(delegated_frame_data);

SurfaceId root_surface_id = allocator_.GenerateId();

@@ -135,7 +135,7 @@ TEST_F(SurfacesPixelTest, DrawSimpleAggregatedFrame) {

new DelegatedFrameData);

delegated_frame_data->render_pass_list.push_back(std::move(pass));

- std::unique_ptr<CompositorFrame> root_frame(new CompositorFrame);

+ std::unique_ptr<CompositorFrame> root_frame(CompositorFrame::Create());

root_frame->delegated_frame_data = std::move(delegated_frame_data);

factory_.SubmitCompositorFrame(root_surface_id, std::move(root_frame),

@@ -164,7 +164,7 @@ TEST_F(SurfacesPixelTest, DrawSimpleAggregatedFrame) {

new DelegatedFrameData);

delegated_frame_data->render_pass_list.push_back(std::move(pass));

- std::unique_ptr<CompositorFrame> child_frame(new CompositorFrame);

+ std::unique_ptr<CompositorFrame> child_frame(CompositorFrame::Create());

child_frame->delegated_frame_data = std::move(delegated_frame_data);

factory_.SubmitCompositorFrame(child_surface_id, std::move(child_frame),

@@ -236,7 +236,7 @@ TEST_F(SurfacesPixelTest, DrawAggregatedFrameWithSurfaceTransforms) {

new DelegatedFrameData);

delegated_frame_data->render_pass_list.push_back(std::move(pass));

- std::unique_ptr<CompositorFrame> root_frame(new CompositorFrame);

+ std::unique_ptr<CompositorFrame> root_frame(CompositorFrame::Create());

root_frame->delegated_frame_data = std::move(delegated_frame_data);

factory_.SubmitCompositorFrame(root_surface_id, std::move(root_frame),

@@ -273,7 +273,7 @@ TEST_F(SurfacesPixelTest, DrawAggregatedFrameWithSurfaceTransforms) {

new DelegatedFrameData);

delegated_frame_data->render_pass_list.push_back(std::move(pass));

- std::unique_ptr<CompositorFrame> child_frame(new CompositorFrame);

+ std::unique_ptr<CompositorFrame> child_frame(CompositorFrame::Create());

child_frame->delegated_frame_data = std::move(delegated_frame_data);

factory_.SubmitCompositorFrame(left_child_id, std::move(child_frame),

@@ -310,7 +310,7 @@ TEST_F(SurfacesPixelTest, DrawAggregatedFrameWithSurfaceTransforms) {

new DelegatedFrameData);

delegated_frame_data->render_pass_list.push_back(std::move(pass));

- std::unique_ptr<CompositorFrame> child_frame(new CompositorFrame);

+ std::unique_ptr<CompositorFrame> child_frame(CompositorFrame::Create());

child_frame->delegated_frame_data = std::move(delegated_frame_data);

factory_.SubmitCompositorFrame(right_child_id, std::move(child_frame),

« cc/output/compositor_frame.cc ('K') | « cc/surfaces/surface_factory_unittest.cc ('k') | cc/test/fake_output_surface.h » ('j') | cc/test/fake_output_surface.h » ('J')