cc/output/output_surface.h - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/output_surface.h

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix reflector Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/output_surface.h

diff --git a/cc/output/output_surface.h b/cc/output/output_surface.h

index 95a52c1edd05ec325c41949eafc7b4e9fdb49673..b45b747f47e88fab97c7367f90f7af40ea7c634e 100644

--- a/cc/output/output_surface.h

+++ b/cc/output/output_surface.h

@@ -141,7 +141,7 @@ class CC_EXPORT OutputSurface : public base::trace_event::MemoryDumpProvider {

// itself). For successful swaps, the implementation must call

// OutputSurfaceClient::DidSwapBuffers() and eventually

// DidSwapBuffersComplete().

- virtual void SwapBuffers(CompositorFrame* frame) = 0;

+ virtual void SwapBuffers(std::unique_ptr<CompositorFrame> frame) = 0;

virtual void OnSwapBuffersComplete();

// Called by subclasses after receiving a response from the gpu process to a