Make cc::CompositorFrames movable [Part 1 of 2]

cc/ipc/cc_param_traits.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/ipc/cc_param_traits.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/numerics/safe_conversions.h"
@@ skipping 656 matching lines @@
   l->append("CompositorFrame(");
   LogParam(p.metadata, l);
   l->append(", ");
   if (p.delegated_frame_data)
     LogParam(*p.delegated_frame_data, l);
   else if (p.gl_frame_data)
     LogParam(*p.gl_frame_data, l);
   l->append(")");
 }
 
+void ParamTraits<std::unique_ptr<cc::CompositorFrame>>::Write(

[dcheng, 2016/06/23 18:39:40]

Shouldn't the existing ParamTraits partial specialization for std::unique_ptr<T>
handle this already?

[Fady Samuel, 2016/06/23 18:47:29]

One exists but it doesn't do what I want. In particular, I don't want to call
"new" directly. The only way to create a CompositorFrame in this patch is
through CompositorFrame::Create() which returns a
unique_ptr<cc::CompositorFrame>.

[danakj, 2016/06/23 20:34:40]

I want to remove all Create() methods that are not needed in cc/. So I don't
think you need this.

+    base::Pickle* m,
+    const param_type& p) {
+  bool valid = !!p;
+  WriteParam(m, valid);
+  if (valid)
+    WriteParam(m, *p);
+}
+
+bool ParamTraits<std::unique_ptr<cc::CompositorFrame>>::Read(
+    const base::Pickle* m,
+    base::PickleIterator* iter,
+    param_type* r) {
+  bool valid = false;
+  if (!ReadParam(m, iter, &valid))
+    return false;
+
+  if (!valid) {
+    r->reset();
+    return true;
+  }
+
+  param_type temp(cc::CompositorFrame::Create());
+  if (!ReadParam(m, iter, temp.get()))
+    return false;
+
+  r->swap(temp);
+  return true;
+}
+
+void ParamTraits<std::unique_ptr<cc::CompositorFrame>>::Log(const param_type& p,
+                                                            std::string* l) {
+  if (p)
+    LogParam(*p, l);
+  else
+    l->append("NULL");
+}
+
 void ParamTraits<cc::CompositorFrameAck>::Write(base::Pickle* m,
                                                 const param_type& p) {
   WriteParam(m, p.resources);
   if (p.gl_frame_data) {
     WriteParam(m, static_cast<int>(GL_FRAME));
     WriteParam(m, *p.gl_frame_data);
   } else {
     WriteParam(m, static_cast<int>(NO_FRAME));
   }
 }
@@ skipping 262 matching lines @@
 #undef CC_IPC_CC_PARAM_TRAITS_MACROS_H_
 #include "cc/ipc/cc_param_traits_macros.h"
 }  // namespace IPC
 
 // Generate param traits log methods.
 #include "ipc/param_traits_log_macros.h"
 namespace IPC {
 #undef CC_IPC_CC_PARAM_TRAITS_MACROS_H_
 #include "cc/ipc/cc_param_traits_macros.h"
 }  // namespace IPC