Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2096433002: Convert prefix search in UserScript code to use base::StartsWith() (Closed)

Created:
4 years, 6 months ago by lazyboy
Modified:
4 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert prefix search in UserScript code to use base::StartsWith() Using string.find('pattern') == 0 is O(|string|), so don't do that. BUG=622464 Test=None, internal only change. Committed: https://crrev.com/28acad804b4c3592ae4aa6465302d895c750c7a6 Cr-Commit-Position: refs/heads/master@{#401451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M extensions/browser/extension_user_script_loader.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/web_ui_user_script_loader.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
lazyboy
4 years, 6 months ago (2016-06-22 21:35:54 UTC) #2
asargent_no_longer_on_chrome
nice catches! lgtm
4 years, 6 months ago (2016-06-22 22:19:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096433002/1
4 years, 6 months ago (2016-06-22 22:37:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 23:14:42 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 23:16:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28acad804b4c3592ae4aa6465302d895c750c7a6
Cr-Commit-Position: refs/heads/master@{#401451}

Powered by Google App Engine
This is Rietveld 408576698