Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2096423002: Split long-running serialization tests to avoid timeouts (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split long-running serialization tests to avoid timeouts Committed: https://github.com/dart-lang/sdk/commit/9445281b0c18dcd766e0e2e2d06b6519357cc47f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -436 lines) Patch
A + tests/compiler/dart2js/serialization/analysis1_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
A + tests/compiler/dart2js/serialization/analysis2_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
D tests/compiler/dart2js/serialization/analysis_test.dart View 1 chunk +0 lines, -65 lines 0 comments Download
A + tests/compiler/dart2js/serialization/analysis_test_helper.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/compiler/dart2js/serialization/compilation1_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
A + tests/compiler/dart2js/serialization/compilation2_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
D tests/compiler/dart2js/serialization/compilation_test.dart View 1 chunk +0 lines, -57 lines 0 comments Download
A + tests/compiler/dart2js/serialization/compilation_test_helper.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/compiler/dart2js/serialization/model1_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
A + tests/compiler/dart2js/serialization/model2_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
D tests/compiler/dart2js/serialization/model_test.dart View 1 chunk +0 lines, -304 lines 0 comments Download
A + tests/compiler/dart2js/serialization/model_test_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
TBR
4 years, 5 months ago (2016-06-27 13:27:34 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 9445281b0c18dcd766e0e2e2d06b6519357cc47f (presubmit successful).
4 years, 5 months ago (2016-06-27 13:29:11 UTC) #4
Harry Terkelsen
4 years, 5 months ago (2016-06-27 17:12:28 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698