Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2096413003: Convert video-delay* and video-display* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-delay* and video-display* tests to testharness.js Cleaning up video-delay* and video-display* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/fb4997976e1c1db6712d1a1b8be871f041eeaf4e Cr-Commit-Position: refs/heads/master@{#402724}

Patch Set 1 #

Total comments: 4

Patch Set 2 : modify as per suggestion #

Messages

Total messages: 17 (7 generated)
Srirama
PTAL
4 years, 5 months ago (2016-06-27 17:28:00 UTC) #3
fs
LGTM w/ suggestion https://codereview.chromium.org/2096413003/diff/1/third_party/WebKit/LayoutTests/media/video-delay-load-event.html File third_party/WebKit/LayoutTests/media/video-delay-load-event.html (right): https://codereview.chromium.org/2096413003/diff/1/third_party/WebKit/LayoutTests/media/video-delay-load-event.html#newcode6 third_party/WebKit/LayoutTests/media/video-delay-load-event.html:6: <body> Is this needed? https://codereview.chromium.org/2096413003/diff/1/third_party/WebKit/LayoutTests/media/video-delay-load-event.html#newcode33 third_party/WebKit/LayoutTests/media/video-delay-load-event.html:33: ...
4 years, 5 months ago (2016-06-27 18:46:38 UTC) #4
Srirama
4 years, 5 months ago (2016-06-28 17:36:05 UTC) #5
fs
On 2016/06/28 at 17:36:05, srirama.m wrote: > lgtm++
4 years, 5 months ago (2016-06-28 17:41:29 UTC) #6
Srirama
https://codereview.chromium.org/2096413003/diff/1/third_party/WebKit/LayoutTests/media/video-delay-load-event.html File third_party/WebKit/LayoutTests/media/video-delay-load-event.html (right): https://codereview.chromium.org/2096413003/diff/1/third_party/WebKit/LayoutTests/media/video-delay-load-event.html#newcode6 third_party/WebKit/LayoutTests/media/video-delay-load-event.html:6: <body> On 2016/06/27 18:46:38, fs wrote: > Is this ...
4 years, 5 months ago (2016-06-28 17:42:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096413003/20001
4 years, 5 months ago (2016-06-28 17:43:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/254033)
4 years, 5 months ago (2016-06-28 20:50:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096413003/20001
4 years, 5 months ago (2016-06-29 03:41:03 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 04:57:38 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 05:00:06 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fb4997976e1c1db6712d1a1b8be871f041eeaf4e
Cr-Commit-Position: refs/heads/master@{#402724}

Powered by Google App Engine
This is Rietveld 408576698