Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2096403002: [turbofan] Introduce simplified operator NumberAbs. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce simplified operator NumberAbs. Add NumberAbs operator to implement an inline version of Math.abs, that can be optimized and eliminated. We don't use any speculation here, but for now stick to the information we can infer (this way we avoid the inherent deopt loops that Crankshaft has around Math.abs). CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel R=jarin@chromium.org BUG=v8:5086 Committed: https://crrev.com/f50a601ffa507ec540e661f67bc752fe88114631 Cr-Commit-Position: refs/heads/master@{#37306}

Patch Set 1 #

Patch Set 2 : Hotfix for minus zero #

Patch Set 3 : Use std::fabs instead of std::abs. #

Patch Set 4 : Really fix the typing rule now. #

Patch Set 5 : Another logic error. #

Patch Set 6 : Fix compile errors #

Patch Set 7 : This time fix the compile error for realz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -2 lines) Patch
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +32 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 2 3 4 5 6 3 chunks +33 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/js/math.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-cache.h View 2 chunks +6 lines, -1 line 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 37 (21 generated)
Benedikt Meurer
4 years, 5 months ago (2016-06-27 13:13:13 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-06-27 13:24:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096403002/1
4 years, 5 months ago (2016-06-27 13:24:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/3867) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-06-27 13:35:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096403002/20001
4 years, 5 months ago (2016-06-27 13:35:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/3837) v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-06-27 14:10:39 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096403002/40001
4 years, 5 months ago (2016-06-27 19:03:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096403002/40001
4 years, 5 months ago (2016-06-27 19:14:57 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/3869) v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-06-27 19:41:29 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096403002/60001
4 years, 5 months ago (2016-06-27 19:45:37 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/18391) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-06-27 19:47:48 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096403002/100001
4 years, 5 months ago (2016-06-27 19:59:17 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/3900) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-06-27 20:01:28 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096403002/120001
4 years, 5 months ago (2016-06-28 03:50:37 UTC) #33
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-06-28 04:34:31 UTC) #35
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 04:37:13 UTC) #37
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/f50a601ffa507ec540e661f67bc752fe88114631
Cr-Commit-Position: refs/heads/master@{#37306}

Powered by Google App Engine
This is Rietveld 408576698