chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ConfirmImportantSitesDialogFragment.java - Issue 2096363003: [ImportantSites] Adding usage metrics.

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ConfirmImportantSitesDialogFragment.java

Issue 2096363003: [ImportantSites] Adding usage metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ConfirmImportantSitesDialogFragment.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ConfirmImportantSitesDialogFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ConfirmImportantSitesDialogFragment.java

index fa168082a907986f651a7f9ee8c1eb54cbbaa1f8..2ed91ce3f82487a40731ba12e9ababc7692bc009 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ConfirmImportantSitesDialogFragment.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ConfirmImportantSitesDialogFragment.java

@@ -31,6 +31,7 @@ import android.widget.ListView;

import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.base.ContextUtils;

import org.chromium.base.VisibleForTesting;

+import org.chromium.base.metrics.RecordHistogram;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.favicon.LargeIconBridge;

import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;

@@ -241,9 +242,11 @@ public class ConfirmImportantSitesDialogFragment extends DialogFragment {

@Override

public Dialog onCreateDialog(Bundle savedInstanceState) {

- if (savedInstanceState != null) {

+ if (savedInstanceState != null || mImportantDomains == null || mFaviconURLs == null) {

dismiss();

}

+ RecordHistogram.recordCount100Histogram(

Theresa 2016/06/27 20:37:53 Same recommendation here wrt to recordCustomCountH

dmurph 2016/06/28 21:41:22 Done.

+ "ClearBrowsingDialog.NumImportant", mImportantDomains.length);

Theresa 2016/06/27 20:37:53 This still needs an entry in histograms.xml, right

dmurph 2016/06/28 21:41:22 Done.

mProfile = Profile.getLastUsedProfile().getOriginalProfile();

mLargeIconBridge = new LargeIconBridge(mProfile);

ActivityManager activityManager =