MacViews: Fix text input for password textfields.

MacViews: Fix text input for password textfields.

crrev.com/2033433006 modified insertText handlers on BridgedContentView to
correctly handle space key events and simplify menu dispatch. However this broke
text input for password textfields.

This CL fixes the issue by introducing a new private method insertTextInternal:
on BridgedContentView, which is used by both insertText: and
insertTextReplacementRange:. Furhter, another private method
activeMenuController: is added to retreive the currently active menu controller.
A textfield test is also added which fails on MacViews for the current master.

This CL is dependent on http://crrev.com/2095283002.

BUG=623036
TEST=Enable Macviews. Open an http auth dialog (Go to
httpwatch.com/httpgallery/authentication/ and click on Display Image button).
Move focus to password textfield and ensure text input works correctly.

Committed: https://crrev.com/25492d28991f4cd464c8d8ab728e548ae735b8a2
Cr-Commit-Position: refs/heads/master@{#403117}

[karandeepb, 2016-06-29 01:34:26]

Description was changed from

==========
Password fix 2
==========

to

==========
MacViews: Fix text input for password textfields.

crrev.com/2033433006 modified insertText handlers on BridgedContentView to
correctly handle space key events and simplify menu dispatch. However this broke
text input for password textfields.

This CL fixes the issue by introducing a new private method insertTextInternal:
on BridgedContentView, which is used by both insertText: and
insertTextReplacementRange:. Furhter, another private method
activeMenuController: is added to retreive the currently active menu controller.
A textfield test is also added which fails on MacViews for the current master.

BUG=623036

TEST=Enable Macviews. Open an http auth dialog (Go to
httpwatch.com/httpgallery/authentication/ and click on Display Image button).
Move focus to password textfield and ensure text input works correctly.
==========

[karandeepb, 2016-06-29 01:34:37]

Patchset #1 (id:1) has been deleted

[karandeepb, 2016-06-29 01:34:46]

Patchset #1 (id:20001) has been deleted

[karandeepb, 2016-06-29 01:43:31]

Description was changed from

==========
MacViews: Fix text input for password textfields.

crrev.com/2033433006 modified insertText handlers on BridgedContentView to
correctly handle space key events and simplify menu dispatch. However this broke
text input for password textfields.

This CL fixes the issue by introducing a new private method insertTextInternal:
on BridgedContentView, which is used by both insertText: and
insertTextReplacementRange:. Furhter, another private method
activeMenuController: is added to retreive the currently active menu controller.
A textfield test is also added which fails on MacViews for the current master.

BUG=623036

TEST=Enable Macviews. Open an http auth dialog (Go to
httpwatch.com/httpgallery/authentication/ and click on Display Image button).
Move focus to password textfield and ensure text input works correctly.
==========

to

==========
MacViews: Fix text input for password textfields.

crrev.com/2033433006 modified insertText handlers on BridgedContentView to
correctly handle space key events and simplify menu dispatch. However this broke
text input for password textfields.

This CL fixes the issue by introducing a new private method insertTextInternal:
on BridgedContentView, which is used by both insertText: and
insertTextReplacementRange:. Furhter, another private method
activeMenuController: is added to retreive the currently active menu controller.
A textfield test is also added which fails on MacViews for the current master.

This CL is dependent on http://crrev.com/2095283002.

BUG=623036
TEST=Enable Macviews. Open an http auth dialog (Go to
httpwatch.com/httpgallery/authentication/ and click on Display Image button).
Move focus to password textfield and ensure text input works correctly.
==========

[karandeepb, 2016-06-29 01:44:09]

karandeepb@chromium.org changed reviewers:
+ tapted@chromium.org

[karandeepb, 2016-06-29 01:44:10]

PTAL Trent.

[tapted, 2016-06-29 07:29:34]

lgtm

https://codereview.chromium.org/2096363002/diff/40001/ui/views/cocoa/bridged_...
File ui/views/cocoa/bridged_content_view.mm (right):

https://codereview.chromium.org/2096363002/diff/40001/ui/views/cocoa/bridged_...
ui/views/cocoa/bridged_content_view.mm:241: // Helper method which forwards
|text| to active menu or |text_input_client_|.
nit: "to the active menu", textInputClient_

https://codereview.chromium.org/2096363002/diff/40001/ui/views/cocoa/bridged_...
ui/views/cocoa/bridged_content_view.mm:433: bool character_event = keyDownEvent_
&& [text length] == 1;
character_event -> isCharacterEvent

[karandeepb, 2016-06-29 08:00:09]

https://codereview.chromium.org/2096363002/diff/40001/ui/views/cocoa/bridged_...
File ui/views/cocoa/bridged_content_view.mm (right):

https://codereview.chromium.org/2096363002/diff/40001/ui/views/cocoa/bridged_...
ui/views/cocoa/bridged_content_view.mm:241: // Helper method which forwards
|text| to active menu or |text_input_client_|.
On 2016/06/29 07:29:34, tapted wrote:
> nit: "to the active menu", textInputClient_

Done.

https://codereview.chromium.org/2096363002/diff/40001/ui/views/cocoa/bridged_...
ui/views/cocoa/bridged_content_view.mm:433: bool character_event = keyDownEvent_
&& [text length] == 1;
On 2016/06/29 07:29:33, tapted wrote:
> character_event -> isCharacterEvent

Done.

[karandeepb, 2016-06-29 08:01:00]

karandeepb@chromium.org changed reviewers:
+ msw@chromium.org

[karandeepb, 2016-06-29 08:01:01]

+msw for ui/views/controls/textfield/textfield_unittest.cc review.

[msw, 2016-06-29 17:26:40]

lgtm with minor comment.

https://codereview.chromium.org/2096363002/diff/60001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield_unittest.cc (right):

https://codereview.chromium.org/2096363002/diff/60001/ui/views/controls/textf...
ui/views/controls/textfield/textfield_unittest.cc:961: SendKeyEvent('a');
Use ui::VKEY_A here, etc. below for 'b' and 'c' (values may differ by platform).

[karandeepb, 2016-06-30 06:03:24]

https://codereview.chromium.org/2096363002/diff/60001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield_unittest.cc (right):

https://codereview.chromium.org/2096363002/diff/60001/ui/views/controls/textf...
ui/views/controls/textfield/textfield_unittest.cc:961: SendKeyEvent('a');
On 2016/06/29 17:26:40, msw wrote:
> Use ui::VKEY_A here, etc. below for 'b' and 'c' (values may differ by
platform).

Done.

[karandeepb, 2016-06-30 07:22:16]

The CQ bit was checked by karandeepb@chromium.org

[karandeepb, 2016-06-30 07:22:16]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org,
msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2096363002/#ps120001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-06-30 07:22:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 08:07:23]

Description was changed from

==========
MacViews: Fix text input for password textfields.

crrev.com/2033433006 modified insertText handlers on BridgedContentView to
correctly handle space key events and simplify menu dispatch. However this broke
text input for password textfields.

This CL fixes the issue by introducing a new private method insertTextInternal:
on BridgedContentView, which is used by both insertText: and
insertTextReplacementRange:. Furhter, another private method
activeMenuController: is added to retreive the currently active menu controller.
A textfield test is also added which fails on MacViews for the current master.

This CL is dependent on http://crrev.com/2095283002.

BUG=623036
TEST=Enable Macviews. Open an http auth dialog (Go to
httpwatch.com/httpgallery/authentication/ and click on Display Image button).
Move focus to password textfield and ensure text input works correctly.
==========

to

==========
MacViews: Fix text input for password textfields.

crrev.com/2033433006 modified insertText handlers on BridgedContentView to
correctly handle space key events and simplify menu dispatch. However this broke
text input for password textfields.

This CL fixes the issue by introducing a new private method insertTextInternal:
on BridgedContentView, which is used by both insertText: and
insertTextReplacementRange:. Furhter, another private method
activeMenuController: is added to retreive the currently active menu controller.
A textfield test is also added which fails on MacViews for the current master.

This CL is dependent on http://crrev.com/2095283002.

BUG=623036
TEST=Enable Macviews. Open an http auth dialog (Go to
httpwatch.com/httpgallery/authentication/ and click on Display Image button).
Move focus to password textfield and ensure text input works correctly.
==========

[commit-bot: I haz the power, 2016-06-30 08:07:24]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-06-30 08:07:26]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 08:10:14]

Description was changed from

==========
MacViews: Fix text input for password textfields.

crrev.com/2033433006 modified insertText handlers on BridgedContentView to
correctly handle space key events and simplify menu dispatch. However this broke
text input for password textfields.

This CL fixes the issue by introducing a new private method insertTextInternal:
on BridgedContentView, which is used by both insertText: and
insertTextReplacementRange:. Furhter, another private method
activeMenuController: is added to retreive the currently active menu controller.
A textfield test is also added which fails on MacViews for the current master.

This CL is dependent on http://crrev.com/2095283002.

BUG=623036
TEST=Enable Macviews. Open an http auth dialog (Go to
httpwatch.com/httpgallery/authentication/ and click on Display Image button).
Move focus to password textfield and ensure text input works correctly.
==========

to

==========
MacViews: Fix text input for password textfields.

crrev.com/2033433006 modified insertText handlers on BridgedContentView to
correctly handle space key events and simplify menu dispatch. However this broke
text input for password textfields.

This CL fixes the issue by introducing a new private method insertTextInternal:
on BridgedContentView, which is used by both insertText: and
insertTextReplacementRange:. Furhter, another private method
activeMenuController: is added to retreive the currently active menu controller.
A textfield test is also added which fails on MacViews for the current master.

This CL is dependent on http://crrev.com/2095283002.

BUG=623036
TEST=Enable Macviews. Open an http auth dialog (Go to
httpwatch.com/httpgallery/authentication/ and click on Display Image button).
Move focus to password textfield and ensure text input works correctly.

Committed: https://crrev.com/25492d28991f4cd464c8d8ab728e548ae735b8a2
Cr-Commit-Position: refs/heads/master@{#403117}
==========

[commit-bot: I haz the power, 2016-06-30 08:10:16]

Patchset 5 (id:??) landed as
https://crrev.com/25492d28991f4cd464c8d8ab728e548ae735b8a2
Cr-Commit-Position: refs/heads/master@{#403117}