Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2096323002: Fix for cross compiling 32bit linux on 64bit host machine (Closed)

Created:
4 years, 5 months ago by ckulakowski
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for cross compiling 32bit linux on 64bit host machine Right now when custom sysroot is provided as gn parameter (target_sysroot) only 32 bit custom sysroot will be used. 64 bit sysroot (which is also needed by 32 bit build by - for example - protobuf) is expected to be found in default location. This change adds possibility to provide path to directory containing both sysroots for linux (32 bit and 64 bit). BUG=622616 Committed: https://crrev.com/16c1060131d3e94aa57a241f3ed33afbdf2f2263 Cr-Commit-Position: refs/heads/master@{#402742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M build/config/sysroot.gni View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
ckulakowski
4 years, 5 months ago (2016-06-27 08:08:58 UTC) #3
ckulakowski
4 years, 5 months ago (2016-06-28 07:19:13 UTC) #4
Dirk Pranke
I guess that's as good as anything I can come up with offhand, and it's ...
4 years, 5 months ago (2016-06-29 01:24:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096323002/1
4 years, 5 months ago (2016-06-29 05:59:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 07:08:13 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/16c1060131d3e94aa57a241f3ed33afbdf2f2263 Cr-Commit-Position: refs/heads/master@{#402742}
4 years, 5 months ago (2016-06-29 07:10:58 UTC) #12
odinho
On 2016/06/29 at 01:24:50, dpranke wrote: > I guess that's as good as anything I ...
4 years, 5 months ago (2016-06-29 08:21:25 UTC) #13
Dirk Pranke
4 years, 5 months ago (2016-06-29 16:02:02 UTC) #14
Message was sent while issue was closed.
On 2016/06/29 08:21:25, odinho wrote:
> On 2016/06/29 at 01:24:50, dpranke wrote:
> > I guess that's as good as anything I can come up with offhand, and it's at
> least simple.
> > 
> > I'm not sure that that's the right long-term option but until someone else
has
> another use for this, lgtm :).
> 
> But does the wheezy-x64 and wheezy-ia32 actually exist anywhere in Chromium? 
> The normal sysroots are called "debian_wheezy_amd64-sysroot" for the ones
> downloaded from Google Cloud Storage.  Will this actually work at all?

This doesn't affect the default builds, since target_sysroot_dir won't be set.

Powered by Google App Engine
This is Rietveld 408576698