components/filesystem/files_test_base.cc - Issue 2096293002: Eliminate usage of InterfacePtr::WaitForIncomingResponse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/filesystem/files_test_base.cc

Issue 2096293002: Eliminate usage of InterfacePtr::WaitForIncomingResponse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybots failure Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/filesystem/files_test_base.cc

diff --git a/components/filesystem/files_test_base.cc b/components/filesystem/files_test_base.cc

index c1a6d8b4fc2f02a05c393a7d726bc1b70d39ca30..37a7509c9e95fa3a1b7573e386377ef23a4fe545 100644

--- a/components/filesystem/files_test_base.cc

+++ b/components/filesystem/files_test_base.cc

@@ -25,8 +25,8 @@ void FilesTestBase::SetUp() {

void FilesTestBase::GetTemporaryRoot(mojom::DirectoryPtr* directory) {

mojom::FileError error = mojom::FileError::FAILED;

- files()->OpenTempDirectory(GetProxy(directory), Capture(&error));

- ASSERT_TRUE(files().WaitForIncomingResponse());

+ bool handled = files()->OpenTempDirectory(GetProxy(directory), &error);

+ ASSERT_TRUE(handled);

ASSERT_EQ(mojom::FileError::OK, error);

}

« no previous file with comments | « components/filesystem/file_impl_unittest.cc ('k') | components/filesystem/public/interfaces/directory.mojom » ('j') | no next file with comments »